Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split galley servant definition #2820

Merged
merged 4 commits into from
Nov 8, 2022
Merged

Split galley servant definition #2820

merged 4 commits into from
Nov 8, 2022

Conversation

pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Nov 3, 2022 •
edited
Loading

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@pcapriotti pcapriotti temporarily deployed to cachix November 3, 2022 09:00 Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Nov 3, 2022
@battermann
Copy link
Contributor

I like this, we should do the same with the route definitions in wire-api.

@pcapriotti
Copy link
Contributor Author

I like this, we should do the same with the route definitions in wire-api.

Sure, I'll make it part of this PR.

@pcapriotti pcapriotti temporarily deployed to cachix November 4, 2022 14:27 Inactive
@pcapriotti pcapriotti marked this pull request as ready for review November 4, 2022 14:30
stefanwire
stefanwire approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@stefanwire stefanwire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no entry in changelog.d/ yet.

@pcapriotti pcapriotti force-pushed the pcapriotti/galley-servant-split branch from 1ba22b7 to 99ff558 Compare November 7, 2022 12:57
@pcapriotti pcapriotti temporarily deployed to cachix November 7, 2022 12:57 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix November 8, 2022 09:13 Inactive
@pcapriotti pcapriotti merged commit 026335b into develop Nov 8, 2022
@pcapriotti pcapriotti deleted the pcapriotti/galley-servant-split branch November 8, 2022 12:47
supersven pushed a commit that referenced this pull request Nov 22, 2022
@pcapriotti @supersven
Split galley servant definition (#2820)
08ec726 
* Split galley servant definition

* Split galley API routes
This was referenced Nov 25, 2022
Closed
Closed
Closed
Merged
Merged
@zebot zebot mentioned this pull request Jan 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanwire stefanwire stefanwire approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pcapriotti @battermann @stefanwire @zebot