WPB:18722: Remove Postgres and smtp hard coded passwords #817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR has a dependent chart update: wireapp/helm-charts#44 |
| echo "⚠️ Warning: PostgreSQL secret exists but password is empty" | ||
| fi | ||
| else | ||
| echo "⚠️ Warning: PostgreSQL secret 'wire-postgresql-secret' not found in namespace '${NAMESPACE}'" |
There was a problem hiding this comment.
no failthrough to the values in the values file?
There was a problem hiding this comment.
Well, I was thinking if I should use the sync-k8s-secret-to-wire-secrets.sh here instead of setting the values as a flag and adding a default value for pgPassword in the secrets.yaml.
There was a problem hiding this comment.
Switched to sync script so both demo and production are aligned now
julialongtin
approved these changes
Oct 17, 2025
sghosh23
force-pushed
the
wpb-18722-hardcoded-pass
branch
from
4736b29 to
2b0ab14
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change type
Basic information
Testing
Tracking
changelog.dKnowledge Transfer
Motivation
Objective
Reason
Use case