Skip to content

feat: Update Cells copies (WPB-17967) #4046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 30, 2025
Merged

feat: Update Cells copies (WPB-17967) #4046

merged 6 commits into from
May 30, 2025

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented May 29, 2025

TaskWPB-17967 [Android] Update folders copies


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  • Update copies.
  • refactor bottom sheet actions, and make it works for files and folders

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@pull-request-size pull-request-size bot added size/M and removed size/L labels May 29, 2025
Copy link

codecov bot commented May 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.90%. Comparing base (1941324) to head (ebca41b).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4046   +/-   ##
========================================
  Coverage    45.90%   45.90%           
========================================
  Files          521      521           
  Lines        18187    18187           
  Branches      3068     3068           
========================================
  Hits          8348     8348           
  Misses        8974     8974           
  Partials       865      865           

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1941324...ebca41b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pull-request-size pull-request-size bot added size/L and removed size/M labels May 30, 2025
Copy link

@ohassine ohassine changed the title feat: Update Cells copies feat: Update Cells copies (WPB-17967) May 30, 2025
@ohassine ohassine added this pull request to the merge queue May 30, 2025
Merged via the queue into develop with commit acc61d7 May 30, 2025
14 of 15 checks passed
@ohassine ohassine deleted the update-copies branch May 30, 2025 14:02
Copy link
Contributor

Built wire-android-staging-compat-pr-4046.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-4046.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants