Skip to content

chore: remove scala migration code and related references [WPB-17693] #4036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented May 26, 2025

TaskWPB-17693 [Android] nuke scala migration


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

it isabout time

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

@MohamadJaara MohamadJaara changed the title chore: remove scala migration code and related references chore: remove scala migration code and related references [WPB-17693] May 26, 2025
@MohamadJaara MohamadJaara requested review from saleniuk and vitorhugods and removed request for saleniuk May 26, 2025 10:20
@MohamadJaara MohamadJaara enabled auto-merge May 26, 2025 10:41
Copy link

codecov bot commented May 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.81%. Comparing base (49b545f) to head (acd478f).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4036      +/-   ##
===========================================
+ Coverage    46.01%   47.81%   +1.79%     
===========================================
  Files          520      489      -31     
  Lines        18140    16892    -1248     
  Branches      3059     2804     -255     
===========================================
- Hits          8348     8077     -271     
+ Misses        8927     7990     -937     
+ Partials       865      825      -40     
Files with missing lines Coverage Δ
...tlin/com/wire/android/datastore/GlobalDataStore.kt 20.00% <ø> (+4.28%) ⬆️
...rc/main/kotlin/com/wire/android/ui/WireActivity.kt 0.00% <ø> (ø)
...otlin/com/wire/android/ui/WireActivityViewModel.kt 74.30% <100.00%> (-1.47%) ⬇️
...com/wire/android/ui/debug/DebugDataOptionsState.kt 100.00% <ø> (ø)
...wire/android/ui/debug/DebugDataOptionsViewModel.kt 55.26% <ø> (+0.06%) ⬆️
.../main/kotlin/com/wire/android/ui/home/HomeState.kt 63.63% <ø> (-0.65%) ⬇️
...n/kotlin/com/wire/android/ui/home/HomeViewModel.kt 87.50% <ø> (+3.01%) ⬆️
...tlin/com/wire/android/util/CurrentScreenManager.kt 26.04% <ø> (+0.26%) ⬆️
...ire/android/util/lifecycle/SyncLifecycleManager.kt 96.87% <ø> (+2.43%) ⬆️
.../com/wire/android/workmanager/WireWorkerFactory.kt 0.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49b545f...acd478f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Copy link
Contributor

Built wire-android-staging-compat-pr-4036.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-4036.apk is available for download

@MohamadJaara MohamadJaara requested a review from ohassine May 27, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants