Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Call stuck connecting state (WPB-15575) #3862

Merged
merged 4 commits into from
Feb 12, 2025

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Feb 6, 2025

BugWPB-15575 [Android] Prolonged "Connecting" on device A mode when call is answered on device B


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

App stuck on connecting screen when users joins a call or when he kills the app and open it again during a call

Solutions

fixed in kalium wireapp/kalium#3282

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. label Feb 6, 2025
@ohassine ohassine requested review from a team, typfel, sbakhtiarov, borichellow, MohamadJaara and emmaoke-w and removed request for a team February 6, 2025 15:24
@ohassine ohassine requested review from Garzas and removed request for typfel and emmaoke-w February 6, 2025 15:25
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.41%. Comparing base (1f0c653) to head (aa61815).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3862   +/-   ##
========================================
  Coverage    45.41%   45.41%           
========================================
  Files          491      491           
  Lines        17021    17021           
  Branches      2850     2850           
========================================
  Hits          7730     7730           
  Misses        8502     8502           
  Partials       789      789           
Files with missing lines Coverage Δ
.../wire/android/ui/calling/SharedCallingViewModel.kt 69.93% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f0c653...aa61815. Read the comment docs.

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Built wire-android-staging-compat-pr-3862.apk is available for download

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Built wire-android-dev-debug-pr-3862.apk is available for download

@MohamadJaara MohamadJaara added this pull request to the merge queue Feb 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Feb 11, 2025
@MohamadJaara MohamadJaara added this pull request to the merge queue Feb 12, 2025
Merged via the queue into develop with commit e0069f5 Feb 12, 2025
12 of 13 checks passed
@MohamadJaara MohamadJaara deleted the call-stuck-connecting branch February 12, 2025 09:40
Copy link
Contributor

Built wire-android-staging-compat-pr-3862.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3862.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants