fix: MLS with unknown signature shown for other users devices WPB-15268 #3827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borichellow
requested review from
sbakhtiarov,
yamilmedina,
Garzas and
saleniuk
echoes-hq
bot
added
the
echoes: product-roadmap/bug
|
yamilmedina
approved these changes
Jan 24, 2025
Garzas
approved these changes
Jan 24, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3827 +/- ##
========================================
Coverage 45.43% 45.43%
========================================
Files 490 490
Lines 16895 16895
Branches 2833 2833
========================================
Hits 7677 7677
Misses 8432 8432
Partials 786 786
Continue to review full report in Codecov by Sentry.
|
|
Built wire-android-staging-compat-pr-3827.apk is available for download |
|
Built wire-android-dev-debug-pr-3827.apk is available for download |
borichellow
deleted the
fix/mls_with_unknown_signature_shown_for_other_users_devices
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
Issues
When we take a look at other users devices after enabling MLS for the team, it shows “MLS with Unknown Signature” above the MLS thumbprint.
Causes (Optional)
The original issue is in CC: type of signature is unknown.
Solutions
To not make user confused: in case of unknown signature type display just "MLS" label instead of "MLS with unknown signature"
Attachments (Optional)