Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter conversation list [WPB-11638] #3555

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Oct 25, 2024

StoryWPB-11638 [Android] User Story for empty conversations/filters


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • renamed MenuBottomSheetItem arguments to leading and trailing
  • added conversation filter button and bottom sheet
  • added empty conversation list for each filter
  • showing favorite conversations will be handled in another PR
screen-20241025-093007.mp4

@Garzas Garzas self-assigned this Oct 25, 2024
@echoes-hq echoes-hq bot added the echoes: features End-user visible changes intended to create customer value label Oct 25, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 56.52174% with 10 lines in your changes missing coverage. Please review.

Project coverage is 45.22%. Comparing base (88ffcdd) to head (6adf9c8).

Files with missing lines Patch % Lines
...ome/conversationslist/ConversationListViewModel.kt 58.33% 4 Missing and 1 partial ⚠️
...tionslist/filter/ConversationFilterSheetContent.kt 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3555   +/-   ##
========================================
  Coverage    45.21%   45.22%           
========================================
  Files          471      472    +1     
  Lines        15732    15750   +18     
  Branches      2630     2632    +2     
========================================
+ Hits          7114     7123    +9     
- Misses        7870     7878    +8     
- Partials       748      749    +1     
Files with missing lines Coverage Δ
...tions/usecase/GetConversationsFromSearchUseCase.kt 86.20% <100.00%> (+1.02%) ⬆️
...ui/home/conversationslist/ConversationListState.kt 100.00% <100.00%> (ø)
...ome/conversationslist/model/ConversationsSource.kt 100.00% <100.00%> (ø)
...ndroid/ui/userprofile/avatarpicker/AvatarPicker.kt 0.00% <ø> (ø)
...ome/conversationslist/ConversationListViewModel.kt 35.22% <58.33%> (+1.22%) ⬆️
...tionslist/filter/ConversationFilterSheetContent.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88ffcdd...6adf9c8. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3555.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3555.apk is available for download

Copy link
Contributor

@borichellow borichellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Just a small wish to improve accessibility ;P

Copy link

sonarcloud bot commented Oct 25, 2024

Copy link
Contributor

Built wire-android-staging-compat-pr-3555.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3555.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: features End-user visible changes intended to create customer value size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants