Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add feature flag for displaying release notes sections (WPB-11702) 🍒 🍒 #3553

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

github-actions[bot]
Copy link
Contributor

This PR was automatically cherry-picked based on the following PR:

Original PR description:


This PR was automatically cherry-picked based on the following PR:

Original PR description:


StoryWPB-11702 [Android] - Repoint New features link to https://social.intranet.bund.de/portal/wirebund


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

For some custom builds, we don't need to display the release notes section

Solutions

Add a feature flag, so it can changed based on the custom build requirements

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…02) 🍒 (#3548)

Co-authored-by: Oussama Hassine <oussama.has100@gmail.com>
@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch size/XS labels Oct 24, 2024
@ohassine ohassine requested review from a team, typfel, alexandreferris, Garzas, saleniuk and mathias-niboulies and removed request for a team October 24, 2024 09:32
Copy link
Contributor Author

Built wire-android-staging-compat-pr-3553.apk is available for download

Copy link
Contributor Author

Built wire-android-dev-debug-pr-3553.apk is available for download

@ohassine ohassine requested review from MohamadJaara and removed request for mathias-niboulies October 24, 2024 10:32
Copy link

sonarcloud bot commented Oct 24, 2024

@ohassine ohassine added this pull request to the merge queue Oct 24, 2024
Copy link
Contributor Author

Built wire-android-staging-compat-pr-3553.apk is available for download

Copy link
Contributor Author

Built wire-android-dev-debug-pr-3553.apk is available for download

Merged via the queue into develop with commit 88ffcdd Oct 24, 2024
11 of 12 checks passed
@ohassine ohassine deleted the feature-flag-release-notes-cherry-pick-cherry-pick branch October 24, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants