Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: initials avatar use regex instead and add content description (WPB-10896) #3433

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Sep 11, 2024

BugWPB-10896 [Android] App is crashing when user does not have an avatar


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Crash when user had more than one space on their name

Causes (Optional)

Not using regex for whitespace

Solutions

  • Use the regex instead
  • Also add content description to the initials avatar for a11y

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina requested review from a team, typfel, alexandreferris, borichellow, MohamadJaara and saleniuk and removed request for a team September 11, 2024 13:13
@yamilmedina yamilmedina changed the title fix: regex and content description (WPB-10896) fix: initials avatar use regex instead and add content description (WPB-10896) Sep 11, 2024
Copy link

sonarcloud bot commented Sep 11, 2024

@yamilmedina yamilmedina removed the request for review from typfel September 11, 2024 13:34
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 44.67%. Comparing base (681a19c) to head (94c4e0d).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
...in/kotlin/com/wire/android/model/UserAvatarData.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3433      +/-   ##
===========================================
- Coverage    44.68%   44.67%   -0.01%     
===========================================
  Files          465      465              
  Lines        15602    15603       +1     
  Branches      2627     2628       +1     
===========================================
  Hits          6971     6971              
- Misses        7880     7881       +1     
  Partials       751      751              
Files with missing lines Coverage Δ
...in/kotlin/com/wire/android/model/UserAvatarData.kt 41.17% <0.00%> (-2.58%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 681a19c...94c4e0d. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3433.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3433.apk is available for download

@yamilmedina yamilmedina added this pull request to the merge queue Sep 12, 2024
Merged via the queue into develop with commit 59fe2d0 Sep 12, 2024
15 checks passed
@yamilmedina yamilmedina deleted the fix/crash-user-noavatar-noinitials branch September 12, 2024 07:02
@echoes-hq echoes-hq bot added the echoes: bugs Technical or functional defects in the product label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: bugs Technical or functional defects in the product size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants