Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(calling): Floating view not visible on top of all UI elements (WPB-10652) - Part 4 #3426

Merged
merged 19 commits into from
Sep 10, 2024

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Sep 9, 2024

StoryWPB-10652 [Android] calling PiP mode


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Floating self user view is not visible on top of all UI elements

Solutions

Call the composable function from an upper class

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

# Conflicts:
#	app/src/main/AndroidManifest.xml
…-user-view-in-PiP-mode

# Conflicts:
#	app/src/main/kotlin/com/wire/android/ui/calling/ongoing/participantsview/ParticipantTile.kt
…-user-view-in-PiP-mode

# Conflicts:
#	app/src/main/kotlin/com/wire/android/ui/calling/ongoing/OngoingCallScreen.kt
#	app/src/main/kotlin/com/wire/android/ui/calling/ongoing/participantsview/FloatingSelfUserTile.kt
#	app/src/main/kotlin/com/wire/android/ui/calling/ongoing/participantsview/ParticipantTile.kt
#	app/src/main/kotlin/com/wire/android/ui/calling/ongoing/participantsview/ParticipantsTiles.kt
#	app/src/main/kotlin/com/wire/android/ui/calling/ongoing/participantsview/gridview/CallingGridView.kt
…PiP-mode' into show-floating-self-user-view-in-PiP-mode
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Sep 9, 2024
@ohassine ohassine requested review from a team, typfel, vitorhugods, mchenani, Garzas and saleniuk and removed request for a team September 9, 2024 15:47
Copy link
Contributor

Built wire-android-staging-compat-pr-3426.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3426.apk is available for download

@ohassine ohassine enabled auto-merge September 10, 2024 13:26
Copy link

@ohassine ohassine added this pull request to the merge queue Sep 10, 2024
Copy link
Contributor

Built wire-android-staging-compat-pr-3426.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3426.apk is available for download

Merged via the queue into develop with commit fab0a2a Sep 10, 2024
11 of 12 checks passed
@ohassine ohassine deleted the floating-view-not-visible branch September 10, 2024 14:12
@echoes-hq echoes-hq bot added echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. and removed echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants