Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: final final final adjust builds for rc branch (WPB-8645) 🍒 #3344

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Aug 19, 2024

EpicWPB-8645 [Android] Infrastructure code and developer experience

Cherry pick of


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

To enable QA we need to build "certain types" for their tests
After back and forth, we aligned into right builds, so this is the final final version.

The details are up-to-date in confluence with the Help of QA.
https://wearezeta.atlassian.net/wiki/x/I4DYSw


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: throughput/ci-maintenance Changes we need to do to keep CI healthy and fast label Aug 19, 2024
@yamilmedina yamilmedina requested review from alexandreferris, saleniuk, a team, borichellow, MohamadJaara and vitorhugods and removed request for a team August 19, 2024 15:28
@yamilmedina yamilmedina changed the title ci: final final final adjust builds for rc branch (WPB-8645) ci: final final final adjust builds for rc branch 🍒 (WPB-8645) Aug 19, 2024
@yamilmedina yamilmedina changed the title ci: final final final adjust builds for rc branch 🍒 (WPB-8645) ci: final final final adjust builds for rc branch (WPB-8645) 🍒 Aug 19, 2024
Copy link

sonarcloud bot commented Aug 19, 2024

Copy link
Contributor

Built wire-android-staging-compat-pr-3344.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3344.apk is available for download

@yamilmedina yamilmedina added this pull request to the merge queue Aug 20, 2024
Merged via the queue into develop with commit 48a778c Aug 20, 2024
16 of 17 checks passed
@yamilmedina yamilmedina deleted the ci/cherrypick-buildsrc branch August 20, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: throughput/ci-maintenance Changes we need to do to keep CI healthy and fast size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants