Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle temporary guest users details (WPB-10454) #3322

Merged
merged 29 commits into from
Aug 14, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Aug 13, 2024

TaskWPB-10454 [Android] Handle temporary guest users


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We don't have handling for temporary users

Causes (Optional)

Not implemented

Solutions

Implement the handling for temporary users; avatar, handle, etc.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Join a conversation as a guest user, you should see indicators about; time left, avatar with indicator.

Notes

Unrelated changes:

  • merging tests from develop about username mapping
  • marking the adr leftovers, action and document

Attachments (Optional)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this Aug 13, 2024
@echoes-hq echoes-hq bot added the echoes: features End-user visible changes intended to create customer value label Aug 13, 2024
@yamilmedina yamilmedina requested review from saleniuk, alexandreferris, MohamadJaara, a team, typfel and borichellow and removed request for a team August 13, 2024 15:34
@AndroidBob
Copy link
Collaborator

AndroidBob commented Aug 13, 2024

New ADR(s) in this PR 📚:

3. Use parameterizable tests in JUnit5

Date: 2024-08-05

Status

Accepted

Context

Sometimes we need to write multiple tests for the same scenario, changing only the input values.

Decision

We will use parameterizable tests in JUnit5 to avoid writing multiple tests for the same scenario.

Consequences

  • Introduction of @ParameterizedTest annotation in the test class
    and library.
  • The test method will receive the parameters as arguments.

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.62%. Comparing base (1808cc8) to head (475e876).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3322   +/-   ##
========================================
  Coverage    44.61%   44.62%           
========================================
  Files          456      456           
  Lines        15380    15382    +2     
  Branches      2563     2564    +1     
========================================
+ Hits          6862     6864    +2     
  Misses        7798     7798           
  Partials       720      720           
Files Coverage Δ
...in/kotlin/com/wire/android/mapper/MessageMapper.kt 61.38% <100.00%> (+0.38%) ⬆️
...e/android/ui/home/conversations/model/UIMessage.kt 51.73% <100.00%> (+0.13%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1808cc8...475e876. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3322.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3322.apk is available for download

Copy link
Contributor

Built wire-android-staging-compat-pr-3322.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3322.apk is available for download

Copy link
Contributor

@alexandreferris alexandreferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work!

I just have one question but not a blocker, mostly curious hehe

Copy link

sonarcloud bot commented Aug 14, 2024

Copy link
Contributor

Built wire-android-staging-compat-pr-3322.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3322.apk is available for download

Copy link
Contributor

@Garzas Garzas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@yamilmedina yamilmedina added this pull request to the merge queue Aug 14, 2024
Merged via the queue into develop with commit e429419 Aug 14, 2024
12 of 13 checks passed
@yamilmedina yamilmedina deleted the feat/guest-users-details branch August 14, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: features End-user visible changes intended to create customer value size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants