Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: support custom app version for fdroid [WPB-10569] #3312

Merged
merged 8 commits into from
Aug 13, 2024

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Aug 12, 2024

TaskWPB-10569 [Android] publish fdroid


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

support a custom app version

Solutions

the fdroid CI will create the file needed to sync the app version and we just need to read it

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@MohamadJaara MohamadJaara changed the title Ci: support custom app version for fdroid ci: support custom app version for fdroid Aug 12, 2024
Copy link

Copy link
Contributor

Built wire-android-staging-compat-pr-3312.apk is available for download

Copy link
Contributor

Built wire-android-internal-compat-pr-3312.apk is available for download

@MohamadJaara MohamadJaara enabled auto-merge August 12, 2024 20:46
@MohamadJaara MohamadJaara disabled auto-merge August 12, 2024 20:47
@MohamadJaara MohamadJaara enabled auto-merge August 13, 2024 07:46
@MohamadJaara MohamadJaara changed the title ci: support custom app version for fdroid ci: support custom app version for fdroid [WPB-10569] Aug 13, 2024
@MohamadJaara MohamadJaara added this pull request to the merge queue Aug 13, 2024
Merged via the queue into release/candidate with commit 81e9652 Aug 13, 2024
14 of 18 checks passed
@MohamadJaara MohamadJaara deleted the ci/fix-fdroid-build branch August 13, 2024 08:25
MohamadJaara added a commit that referenced this pull request Aug 13, 2024
Co-authored-by: yamilmedina <yamilmedina@users.noreply.github.com>

(cherry picked from commit 81e9652)
MohamadJaara added a commit that referenced this pull request Aug 16, 2024
Co-authored-by: yamilmedina <yamilmedina@users.noreply.github.com>

(cherry picked from commit 81e9652)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants