Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate effects file on demand [WPB-9713] #3297

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Aug 7, 2024

TaskWPB-9713 [Android] Generate the audio filter file on demand when needed after recording


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

File containing recorded audio filter was created even when it was not needed after recording

Causes (Optional)

Takes longer time to prepare audio file without filter

Solutions

Create audio file with filter on demand, when:

  • user clicks filter before recording -> prepare file after recording
  • user clicks filter after recording -> show encoding state and prepare file with filter

Copy link

sonarqubecloud bot commented Aug 7, 2024

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 60.37736% with 21 lines in your changes missing coverage. Please review.

Project coverage is 44.55%. Comparing base (9704c19) to head (f0dbe58).

Files Patch % Lines
...essagecomposer/recordaudio/RecordAudioViewModel.kt 61.53% 16 Missing and 4 partials ⚠️
.../messagecomposer/recordaudio/AudioMediaRecorder.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3297      +/-   ##
=====================================================
+ Coverage              44.44%   44.55%   +0.11%     
=====================================================
  Files                    453      453              
  Lines                  15302    15331      +29     
  Branches                2554     2558       +4     
=====================================================
+ Hits                    6801     6831      +30     
+ Misses                  7785     7782       -3     
- Partials                 716      718       +2     
Files Coverage Δ
.../messagecomposer/recordaudio/AudioMediaRecorder.kt 0.00% <0.00%> (ø)
...essagecomposer/recordaudio/RecordAudioViewModel.kt 64.70% <61.53%> (+4.44%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9704c19...f0dbe58. Read the comment docs.

Copy link
Contributor

github-actions bot commented Aug 7, 2024

Built wire-android-staging-compat-pr-3297.apk is available for download

Copy link
Contributor

github-actions bot commented Aug 7, 2024

Built wire-android-internal-compat-pr-3297.apk is available for download

@Garzas Garzas enabled auto-merge August 8, 2024 09:52
@Garzas Garzas added this pull request to the merge queue Aug 8, 2024
Merged via the queue into release/candidate with commit 48610a2 Aug 8, 2024
12 checks passed
@Garzas Garzas deleted the feat/generate-effects-file-on-demand branch August 8, 2024 12:21
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants