Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: missing codecov token (WPB-8645) #3271

Merged
merged 9 commits into from
Aug 1, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Aug 1, 2024

EpicWPB-8645 [Android] Infrastructure code and developer experience


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Token was not being passed to the Workflow

Causes (Optional)

We modified some months ago the unit-test workflow to be triggered by "workflow_call".
When this happens, we need to pass the secrets from the caller side.

Solutions

Pass the secret when calling the workflow.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina changed the title ci: missing codecov token ci: missing codecov token (WPB-8546) Aug 1, 2024
@yamilmedina yamilmedina marked this pull request as ready for review August 1, 2024 15:27
@yamilmedina yamilmedina requested review from MohamadJaara, vitorhugods, alexandreferris, a team, borichellow and ohassine and removed request for a team August 1, 2024 15:30
@yamilmedina yamilmedina changed the title ci: missing codecov token (WPB-8546) ci: missing codecov token (WPB-4586) Aug 1, 2024
@yamilmedina yamilmedina changed the title ci: missing codecov token (WPB-4586) ci: missing codecov token (WPB-8645) Aug 1, 2024
@yamilmedina yamilmedina enabled auto-merge August 1, 2024 15:31
Copy link

sonarqubecloud bot commented Aug 1, 2024

@yamilmedina yamilmedina added this pull request to the merge queue Aug 1, 2024
@yamilmedina
Copy link
Contributor Author

yamilmedina commented Aug 1, 2024

Finally 🥳 not failing anymore
https://app.codecov.io/github/wireapp/wire-android/commit/155490e4057715cc20d2034f607b54258781e567

Merged via the queue into release/candidate with commit 7c917d4 Aug 1, 2024
16 of 18 checks passed
@yamilmedina yamilmedina deleted the fix/codecov-foronce branch August 1, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants