-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: missing codecov token (WPB-8645) #3271
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamilmedina
changed the title
ci: missing codecov token
ci: missing codecov token (WPB-8546)
Aug 1, 2024
This reverts commit 87facdd.
yamilmedina
requested review from
MohamadJaara,
vitorhugods,
alexandreferris,
a team,
borichellow and
ohassine
and removed request for
a team
August 1, 2024 15:30
yamilmedina
changed the title
ci: missing codecov token (WPB-8546)
ci: missing codecov token (WPB-4586)
Aug 1, 2024
yamilmedina
changed the title
ci: missing codecov token (WPB-4586)
ci: missing codecov token (WPB-8645)
Aug 1, 2024
Quality Gate passedIssues Measures |
MohamadJaara
approved these changes
Aug 1, 2024
alexandreferris
approved these changes
Aug 1, 2024
Finally 🥳 not failing anymore |
This was referenced Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Token was not being passed to the Workflow
Causes (Optional)
We modified some months ago the unit-test workflow to be triggered by "workflow_call".
When this happens, we need to pass the secrets from the caller side.
Solutions
Pass the secret when calling the workflow.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.