fix: disable clicks under record audio [WPB-9619] #3255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garzas
requested review from
alexandreferris,
ohassine,
saleniuk,
a team,
yamilmedina and
MohamadJaara
and removed request for
a team
echoes-hq
bot
added
the
echoes: unplanned
saleniuk
reviewed
Jul 30, 2024
Comment on lines
98
to
102
| .clickable( | ||
| interactionSource = remember { MutableInteractionSource() }, | ||
| indication = null, | ||
| onClick = { /* Don't allow to click on elements under record area */ } | ||
| ) |
There was a problem hiding this comment.
suggestion: use pointerInput instead of clickable to block any touch interaction, not just clicks
Suggested change
| .clickable( | |
| interactionSource = remember { MutableInteractionSource() }, | |
| indication = null, | |
| onClick = { /* Don't allow to click on elements under record area */ } | |
| ) | |
| .pointerInput(Unit) { /* Don't allow to click on elements under record area */ } |
|
Built wire-android-staging-compat-pr-3255.apk is available for download |
|
Built wire-android-internal-compat-pr-3255.apk is available for download |
|
saleniuk
approved these changes
Jul 31, 2024
|
Built wire-android-staging-compat-pr-3255.apk is available for download |
|
Built wire-android-internal-compat-pr-3255.apk is available for download |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Buttons under record message area were clickable
Solutions
Add clickable to record area box with disabled ripple effect to avoid clicks under this area