fix: keep screen on during ongoing call [WPB-9033] #3209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into fix/video-call-keep-screen-on
echoes-hq
bot
added
the
echoes: unplanned
saleniuk
requested review from
a team,
yamilmedina,
borichellow,
MohamadJaara,
vitorhugods and
ohassine
and removed request for
a team
|
Built wire-android-staging-release-pr-3209.apk is available for download |
|
Built wire-android-internal-compat-pr-3209.apk is available for download |
alexandreferris
approved these changes
Jul 19, 2024
ohassine
approved these changes
Jul 22, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
yamilmedina
removed this pull request from the merge queue due to the queue being cleared
|
Built wire-android-staging-release-pr-3209.apk is available for download |
|
Built wire-android-internal-compat-pr-3209.apk is available for download |
saleniuk
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
|
|
Built wire-android-staging-release-pr-3209.apk is available for download |
|
Built wire-android-internal-compat-pr-3209.apk is available for download |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-actions bot
pushed a commit
that referenced
this pull request
Jul 22, 2024
Co-authored-by: Yamil Medina <yamilmedina@users.noreply.github.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
When we are in an active video call with video enabled and the phone locks itself in the background, my own video is freezed and the calling UI disappears.
Causes (Optional)
It looks like we missed the part of keeping screen on when making call refactors.
Solutions
Bring back adding and removing flags to keep screen on during ongoing call.
Testing
How to Test
Create or join a call and check if the screen turns off during the call.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.