Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: upload apk to latest release after uploading to playstore (WPB-8645) #3203

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Jul 18, 2024

EpicWPB-8645 [Android] Infrastructure code and developer experience


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Solves

Causes (Optional)

Increased complexity to implement with the old CI

Solutions

Now that we are using GH actions, we can just upload the apk when built.
The release action automatically updates the latest release associated with tag.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this Jul 18, 2024
@yamilmedina yamilmedina requested review from MohamadJaara, a team, typfel, mchenani, Garzas, ohassine, alexandreferris and vitorhugods and removed request for a team July 18, 2024 16:35
@yamilmedina yamilmedina changed the title chore: upload apk to latest release after uploading to playstore (WPB-8645) ci: upload apk to latest release after uploading to playstore (WPB-8645) Jul 18, 2024
Copy link
Contributor

Built wire-android-staging-release-pr-3203.apk is available for download

Copy link
Contributor

Built wire-android-internal-compat-pr-3203.apk is available for download

@yamilmedina yamilmedina enabled auto-merge (squash) July 18, 2024 19:40
Copy link

Copy link
Contributor

Built wire-android-staging-release-pr-3203.apk is available for download

Copy link
Contributor

Built wire-android-internal-compat-pr-3203.apk is available for download

@yamilmedina yamilmedina merged commit dac4d40 into release/candidate Jul 19, 2024
11 of 12 checks passed
@yamilmedina yamilmedina deleted the chore/uploadarticat-release branch July 19, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants