Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: include crowdin translations updater for modules (WPB-10073) #3172

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Jul 9, 2024

TaskWPB-10073 [Android] Update crowdin config for modules


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

With the introduction of modules, we don't have a way to update the translations or even this be visibily in crowdin.

Causes (Optional)

Outdated config.

Solutions

Configure crowdin to take new modules into consideration for this update automation.

Testing

N/A

How to Test

We need to see when this is merged to develop, since at that moment the string sources are uploaded.


PR Post Submission Checklist for internal contributors (Optional)

  • [] Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this Jul 9, 2024
@yamilmedina yamilmedina requested review from typfel, borichellow and vitorhugods and removed request for a team July 9, 2024 09:12
@yamilmedina yamilmedina changed the title chore: crowding translations updater for modules (WPB-10073) chore: crowdin translations updater for modules (WPB-10073) Jul 9, 2024
@yamilmedina yamilmedina changed the title chore: crowdin translations updater for modules (WPB-10073) chore: include crowdin translations updater for modules (WPB-10073) Jul 9, 2024
Copy link

sonarcloud bot commented Jul 9, 2024

@yamilmedina yamilmedina added this pull request to the merge queue Jul 9, 2024
Merged via the queue into develop with commit ba32a7d Jul 9, 2024
10 of 11 checks passed
@yamilmedina yamilmedina deleted the chore/crowdin-for-mudules branch July 9, 2024 10:14
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Built wire-android-staging-compat-pr-3172.apk is available for download

Copy link
Contributor

github-actions bot commented Jul 9, 2024

Built wire-android-dev-debug-pr-3172.apk is available for download

@echoes-hq echoes-hq bot added the echoes: throughput/ci-maintenance Changes we need to do to keep CI healthy and fast label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: throughput/ci-maintenance Changes we need to do to keep CI healthy and fast size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants