Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): github action deadlock in merge_group #3048

Merged
merged 1 commit into from
May 28, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented May 28, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We are having a "gh action deadlock" while trying to cancel concurrent workflows.

Solutions

Remove from, ui-test workflow the concurrent cancellation, since now is only triggered by workflow call, the concurrent handling is done on the caller side, ie: build flows.

Attachments

Wire 2024-05-28 at 4_39 PM

https://github.com/wireapp/wire-android/actions/runs/9270149211

How to Test

We need to test manually, the workflows should not be stuck on merge_group


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina requested review from ohassine, a team, typfel, alexandreferris, borichellow and mchenani and removed request for a team May 28, 2024 15:03
@yamilmedina yamilmedina changed the title fix(ci): github action deadlock in merge_group, cancelling from child fix(ci): github action deadlock in merge_group May 28, 2024
Copy link

sonarcloud bot commented May 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@yamilmedina yamilmedina added this pull request to the merge queue May 28, 2024
@AndroidBob
Copy link
Collaborator

Build 5056 succeeded.

The build produced the following APK's:

Merged via the queue into develop with commit f95ed2b May 28, 2024
16 checks passed
@yamilmedina yamilmedina deleted the fix/gh-merge-group-concurrentdeadlock branch May 28, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants