Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash on code screen while requesting focus (WPB-6876) #3043

Merged
merged 7 commits into from
May 28, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented May 28, 2024

BugWPB-6876 [Android] Crash in CreateAccountCodeScreen.CodeContent


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Sometimes when requesting focus, we are having an unhandled Exception:

Exception java.lang.IllegalStateException: FocusRequester is not initialized

Causes (Optional)

Crash when requesting focus during composition.

Solutions

The solutions suggested, were, applying delay, using onGloballyPositioned and the selected one:
Applying requestFocus call inside a coroutineContext.invokeOnCompletion so the effect will be canceled when leaving composition.

Testing

How to Test

Manually tested.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina requested review from saleniuk and a team May 28, 2024 08:08
@yamilmedina yamilmedina self-assigned this May 28, 2024
@yamilmedina yamilmedina requested review from borichellow, MohamadJaara, vitorhugods and Garzas and removed request for a team May 28, 2024 08:08
@AndroidBob
Copy link
Collaborator

Build 5025 failed.

Copy link
Contributor

github-actions bot commented May 28, 2024

Test Results

931 tests  ±0   931 ✅ ±0   7m 43s ⏱️ - 1m 59s
124 suites ±0     0 💤 ±0 
124 files   ±0     0 ❌ ±0 

Results for commit d75760f. ± Comparison against base commit 40ebea4.

♻️ This comment has been updated with latest results.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 5031 succeeded.

The build produced the following APK's:

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.32%. Comparing base (40ebea4) to head (d75760f).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3043      +/-   ##
===========================================
+ Coverage    44.15%   44.32%   +0.16%     
===========================================
  Files          450      450              
  Lines        14520    14521       +1     
  Branches      2496     2497       +1     
===========================================
+ Hits          6411     6436      +25     
+ Misses        7407     7375      -32     
- Partials       702      710       +8     

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40ebea4...d75760f. Read the comment docs.

Copy link

sonarcloud bot commented May 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@yamilmedina yamilmedina added this pull request to the merge queue May 28, 2024
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit 0fee9fe May 28, 2024
13 of 14 checks passed
@yamilmedina yamilmedina deleted the fix/crash-code-scree-requestfocus branch May 28, 2024 10:37
@AndroidBob
Copy link
Collaborator

Build 5037 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants