-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: crash on code screen while requesting focus (WPB-6876) #3043
Conversation
This reverts commit 49be809.
Build 5025 failed. |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 5031 succeeded. The build produced the following APK's: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3043 +/- ##
===========================================
+ Coverage 44.15% 44.32% +0.16%
===========================================
Files 450 450
Lines 14520 14521 +1
Branches 2496 2497 +1
===========================================
+ Hits 6411 6436 +25
+ Misses 7407 7375 -32
- Partials 702 710 +8 see 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Quality Gate passedIssues Measures |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 5037 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Sometimes when requesting focus, we are having an unhandled Exception:
Exception java.lang.IllegalStateException: FocusRequester is not initialized
Causes (Optional)
Crash when requesting focus during composition.
Solutions
The solutions suggested, were, applying delay, using
onGloballyPositioned
and the selected one:Applying
requestFocus
call inside acoroutineContext.invokeOnCompletion
so the effect will be canceled when leaving composition.Testing
How to Test
Manually tested.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.