Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash when no browser available (WPB-9436) #3041

Merged
merged 2 commits into from
May 28, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented May 27, 2024

BugWPB-9436 [Android] Playstore crash - Customtab opening on >= Android 11


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

If the app has no browser available to handle opening a URL, the app crashes.

Solutions

For now, as discussed in https://wearezeta.atlassian.net/browse/WPB-9436?focusedCommentId=124984
We handle it and log it, there is no extra action needed for now.

How to Test

Disable and/or delete all browsers in the phone, before the app was crashing, now it just does nothing, but you can see logs for it either locally or in datadog.

Attachments (Optional)

Screen_Recording_20240527_165038_One.UI.Home.mp4

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this May 27, 2024
@yamilmedina yamilmedina requested review from a team, borichellow, MohamadJaara, vitorhugods, Garzas, saleniuk and alexandreferris and removed request for a team May 27, 2024 14:57
Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 44.22%. Comparing base (1522528) to head (0df26bd).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3041      +/-   ##
===========================================
- Coverage    44.26%   44.22%   -0.04%     
===========================================
  Files          450      450              
  Lines        14513    14520       +7     
  Branches      2496     2496              
===========================================
- Hits          6424     6422       -2     
- Misses        7386     7395       +9     
  Partials       703      703              
Files Coverage Δ
...n/kotlin/com/wire/android/util/CustomTabsHelper.kt 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1522528...0df26bd. Read the comment docs.

Copy link
Contributor

Test Results

931 tests  ±0   931 ✅ ±0   12m 30s ⏱️ + 3m 13s
124 suites ±0     0 💤 ±0 
124 files   ±0     0 ❌ ±0 

Results for commit 0df26bd. ± Comparison against base commit 1522528.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 5019 succeeded.

The build produced the following APK's:

@yamilmedina yamilmedina added this pull request to the merge queue May 28, 2024
Merged via the queue into develop with commit 19032ec May 28, 2024
16 checks passed
@yamilmedina yamilmedina deleted the fix/crash-when-no-browser branch May 28, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants