Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sketch general issues (WPB-8810) (WPB-8811) (WPB-8812) #2919

Merged
merged 5 commits into from
Apr 22, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Apr 22, 2024

BugWPB-8810 [Android] Sketcher Undo button works on 3rd tap


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  • Color picker, didn't consider the status bar padding
  • When Keyboard open, the drawing showed a loop collapsing keyboard and no drawing mode.
  • Undo button took at least 3 taps to perform action.
  • Darkmode title not visible

Solutions

  • Add padding to common component, to consider status bar on modal sheet if not consumed.
  • Ignore consumed paths that are irrelevant, so undo perform is consistent with drew paths.
  • Set title color accordingly to theme.

Attachments (Optional)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this Apr 22, 2024
@@ -104,7 +105,7 @@ fun DrawingCanvasBottomSheet(
onDismissRequest = onDismissEvent,
properties = ModalBottomSheetProperties(
isFocusable = true,
securePolicy = SecureFlagPolicy.SecureOn,
securePolicy = SecureFlagPolicy.Inherit,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Black screen issue fix

@@ -172,7 +172,7 @@ private suspend fun AwaitPointerEventScope.handleGestures(
do {
val event = awaitPointerEvent()
onDraw(event.changes.first().position)
val hasNewLineDraw = event.changes.first().positionChangedIgnoreConsumed()
val hasNewLineDraw = event.changes.first().positionChanged()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several undo actions to execute fix.

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 43.85%. Comparing base (37a0fe5) to head (4264455).

❗ Current head 4264455 differs from pull request most recent head e1629eb. Consider uploading reports for the commit e1629eb to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2919      +/-   ##
===========================================
- Coverage    43.95%   43.85%   -0.10%     
===========================================
  Files          441      441              
  Lines        14318    14317       -1     
  Branches      2478     2477       -1     
===========================================
- Hits          6293     6279      -14     
- Misses        7334     7354      +20     
+ Partials       691      684       -7     
Files Coverage Δ
...m/wire/android/feature/sketch/DrawingToolPicker.kt 0.00% <ø> (ø)
...e/android/feature/sketch/DrawingCanvasComponent.kt 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37a0fe5...e1629eb. Read the comment docs.

Copy link
Contributor

github-actions bot commented Apr 22, 2024

Test Results

900 tests  ±0   900 ✅ ±0   12m 55s ⏱️ -29s
122 suites ±0     0 💤 ±0 
122 files   ±0     0 ❌ ±0 

Results for commit e1629eb. ± Comparison against base commit 37a0fe5.

♻️ This comment has been updated with latest results.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@yamilmedina yamilmedina requested review from saleniuk, alexandreferris, Garzas, a team, MohamadJaara and vitorhugods and removed request for a team April 22, 2024 11:31
@yamilmedina yamilmedina changed the title fix: sketch general issues fix: sketch general issues (WPB-8810) (WPB-8811) (WPB-8812) Apr 22, 2024
@yamilmedina yamilmedina marked this pull request as ready for review April 22, 2024 11:56
@yamilmedina yamilmedina added this pull request to the merge queue Apr 22, 2024
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit 8aa0aea Apr 22, 2024
11 of 12 checks passed
@yamilmedina yamilmedina deleted the fix/sketch-issues branch April 22, 2024 12:47
@AndroidBob
Copy link
Collaborator

Build 4367 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants