Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close properly keyboard in conversation screen [WPB-7630] #2872

Merged
merged 3 commits into from
Apr 8, 2024
Merged

fix: close properly keyboard in conversation screen [WPB-7630] #2872

merged 3 commits into from
Apr 8, 2024

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Apr 8, 2024 •
edited by github-actions bot
Loading

BugWPB-7630 [Android] Keyboard shows for a short time on conversation list

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • keyboard was focusing when conversation was closing -> added collapseComposer to disable it
  • added onPreInterceptKeyBeforeSoftKeyboard to avoid keyboard blinking when textfield collapses

Before

blinking_closing_conversation.mp4
blinking_in_conversation.mp4

After

keyboard_after.mp4

@Garzas Garzas requested review from yamilmedina, alexandreferris and a team April 8, 2024 11:14
@Garzas Garzas self-assigned this Apr 8, 2024
@Garzas Garzas requested review from mchenani, ohassine and saleniuk and removed request for a team April 8, 2024 11:14
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2024 •
edited
Loading

Test Results

816 tests   816 ✅  10m 42s ⏱️
110 suites    0 💤
110 files      0 ❌

Results for commit 1e9242c.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 4048 failed.

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Apr 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2024

APKs built during tests are available here. Scroll down to Artifacts!

borichellow
borichellow approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@borichellow borichellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good :)

@AndroidBob
Copy link
Collaborator

Build 4049 succeeded.

The build produced the following APK's:

@Garzas Garzas merged commit 8565a3e into release/candidate Apr 8, 2024
12 checks passed
@Garzas Garzas deleted the fix/close-keyboard-in-conversation branch April 8, 2024 14:38
@AndroidBob AndroidBob mentioned this pull request Apr 8, 2024
Merged
4 tasks
@Garzas Garzas restored the fix/close-keyboard-in-conversation branch April 9, 2024 09:56
@yamilmedina yamilmedina deleted the fix/close-keyboard-in-conversation branch July 30, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandreferris alexandreferris alexandreferris approved these changes

@borichellow borichellow borichellow approved these changes

@yamilmedina yamilmedina Awaiting requested review from yamilmedina

@mchenani mchenani Awaiting requested review from mchenani mchenani was automatically assigned from wireapp/android

@ohassine ohassine Awaiting requested review from ohassine ohassine was automatically assigned from wireapp/android

@saleniuk saleniuk Awaiting requested review from saleniuk saleniuk was automatically assigned from wireapp/android

Assignees

@Garzas Garzas

Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Garzas @AndroidBob @alexandreferris @borichellow