Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump develop to v4.6.x #2425

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@CLAassistant
Copy link

CLAassistant commented Nov 14, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ saleniuk
❌ MohamadJaara


MohamadJaara seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #2425 (9f50467) into develop (db858ea) will decrease coverage by 0.01%.
Report is 5 commits behind head on develop.
The diff coverage is 26.66%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2425      +/-   ##
=============================================
- Coverage      41.56%   41.55%   -0.01%     
+ Complexity      1084     1079       -5     
=============================================
  Files            344      344              
  Lines          12471    12473       +2     
  Branches        1634     1635       +1     
=============================================
  Hits            5183     5183              
- Misses          6803     6805       +2     
  Partials         485      485              
Files Coverage Δ
...poser/attachments/IsFileSharingEnabledViewModel.kt 0.00% <0.00%> (ø)
...ui/home/conversations/CompositeMessageViewModel.kt 88.88% <60.00%> (-11.12%) ⬇️
...d/ui/connection/ConnectionActionButtonViewModel.kt 74.48% <11.11%> (+0.75%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 353bb69...9f50467. Read the comment docs.

Copy link
Contributor

github-actions bot commented Nov 14, 2023

Test Results

680 tests   680 ✔️  10m 0s ⏱️
  98 suites      0 💤
  98 files        0

Results for commit 9f50467.

♻️ This comment has been updated with latest results.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1815 succeeded.

The build produced the following APK's:

@saleniuk saleniuk changed the title chore: bump develop to 4.6.x chore: bump develop to 4.6.x Nov 14, 2023
@saleniuk saleniuk changed the title chore: bump develop to 4.6.x chore: bump develop to v4.6.x Nov 14, 2023
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1822 succeeded.

The build produced the following APK's:

@MohamadJaara MohamadJaara added this pull request to the merge queue Nov 15, 2023
Merged via the queue into develop with commit 4a25e69 Nov 15, 2023
11 checks passed
@MohamadJaara MohamadJaara deleted the chore/chore-bump-develop-to-4.6.x branch November 15, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants