refactor: optimise paginated conversation list queries [WPB-11808] 🍒 #3078
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…3074) * refactor: optimise paginated conversation list queries [WPB-11808] * detekt * fixed tests
github-actions
bot
added
cherry-pick
|
|
Bencher Report| Branch | refactor/optimise-conversation-list-queries-cherry-pick |
| Testbed | ubuntu-latest |
⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | nanoseconds (ns) |
|---|---|---|
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles | 📈 view plot | 662,070.97 |
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory | 📈 view plot | 403,607,537.78 |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark | 📈 view plot | 930,858,552.37 |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark | 📈 view plot | 21,456,817.85 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3078 +/- ##
===========================================
- Coverage 52.71% 52.55% -0.16%
===========================================
Files 1317 1318 +1
Lines 51111 51449 +338
Branches 4741 4772 +31
===========================================
+ Hits 26943 27041 +98
- Misses 22243 22447 +204
- Partials 1925 1961 +36
... and 16 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 3145 Passed, 106 Skipped, 29.64s Total Time |
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
The app stalls when fetching a page of conversations from the local DB.
Causes (Optional)
Our queries for fetching conversation list pages are very complex, many joins with different tables resulting in full table scans, especially Message table.
Solutions
Optimised queries, joins made directly instead of using views so that it doesn't make full scans but just searches using existing indexes. Also rearranged joins to get self user so that it's executed once and not 4 times
Removed all unnecessary joins from query that only counts elements.
Moved
ConversationDetailsandConversationDetailsWithEventsviews to dedicated files along with all queries related to them and unify naming of functions.Making a search with wildcard character % at the beginning results in full table scan of conversations (https://www.sqlite.org/optoverview.html#the_like_optimization) so now it's separated by creating two functions: for searching conversations with query and just fetching without searching, so that it doesn't scan if it's not actually necessary.
Testing
Test Coverage (Optional)
How to Test
Check how query is executed by calling
EXPLAIN QUERY PLAN...or just open the app and scroll the conversations.Attachments (Optional)
Query before:
Query after:
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.