feat: Initialize mls only according to backend feature flag #WPB-10117 #3076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes/initiative: federation-wire-cloud
|
MohamadJaara
requested changes
Oct 25, 2024
Comment on lines
65
to
75
| val mlsKey = mlsClientProvider.getMLSClient().flatMap { mlsClient -> | ||
| val cipherSuite: CipherSuite = CipherSuite.fromTag(mlsClient.getDefaultCipherSuite()) | ||
| mlsPublicKeysRepository.getKeyForCipherSuite(cipherSuite) | ||
| } | ||
|
|
||
| return if (!featureSupport.isMLSSupported || mlsKey.isLeft()) { | ||
| logger.d( | ||
| "Skip updating supported protocols, since MLS is not supported. " + | ||
| "Feature flag: ${featureSupport.isMLSSupported} " + | ||
| "Has mls key: ${mlsKey.isRight()}" | ||
| ) |
There was a problem hiding this comment.
question: not sure what this changes from the code before?
Creating an object of MLS client will create some local files/db for MLS and if there is no need to create it uus better to not init mls untill it is needed
There was a problem hiding this comment.
- looking at the Jira ticket i think the app is already doing what it described in the ticket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-10119
What's new in this PR?
Issues
All clients need to align on when they register an MLS client by only doing so when the following conditions are fulfilled:
Solutions
Testing
How to Test
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.