-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Initialize mls only according to backend feature flag #WPB-10117 #3076
base: develop
Are you sure you want to change the base?
feat: Initialize mls only according to backend feature flag #WPB-10117 #3076
Conversation
Quality Gate passedIssues Measures |
val mlsKey = mlsClientProvider.getMLSClient().flatMap { mlsClient -> | ||
val cipherSuite: CipherSuite = CipherSuite.fromTag(mlsClient.getDefaultCipherSuite()) | ||
mlsPublicKeysRepository.getKeyForCipherSuite(cipherSuite) | ||
} | ||
|
||
return if (!featureSupport.isMLSSupported || mlsKey.isLeft()) { | ||
logger.d( | ||
"Skip updating supported protocols, since MLS is not supported. " + | ||
"Feature flag: ${featureSupport.isMLSSupported} " + | ||
"Has mls key: ${mlsKey.isRight()}" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: not sure what this changes from the code before?
Creating an object of MLS client will create some local files/db for MLS and if there is no need to create it uus better to not init mls untill it is needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- looking at the Jira ticket i think the app is already doing what it described in the ticket
https://wearezeta.atlassian.net/browse/WPB-10119
What's new in this PR?
Issues
All clients need to align on when they register an MLS client by only doing so when the following conditions are fulfilled:
Solutions
Testing
How to Test
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.