fix: black screen when last caller in a group #WPB-10652

[damian-kaczmarek]

WPB-10652 [Android] calling PiP mode

What's new in this PR?

Issues

Couldn't reproduce the original issue but was able to reproduce black screen in following scenario:

• call to a group from account A
• join to call with account B
• enable video on account A
• leave the call with account B
• user A was left with a black screen instead of their own camera preview

Causes (Optional)

There was assumption that on list of participants first account is user currently logged it. Based on that first() was called. This was no longer true with picture in picture enabled as self participant was then removed.

Solutions

Used currently logged in UserId and compared it to a participant to decide if given call tile is selfUser.

Testing

How to Test

• call to a group from account A
• join to call with account B
• enable video on account A
• leave the call with account B
• user A should see own preview video

Attachments (Optional)

Before:

before.mp4

After:

after.mp4

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[github-actions]

Test Results

3 256 tests  +5   3 150 ✅ +5   4m 28s ⏱️ +34s
  556 suites +1     106 💤 ±0 
  556 files   +1       0 ❌ ±0 

Results for commit b27f974. ± Comparison against base commit 71aef39.

♻️ This comment has been updated with latest results.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 52.68%. Comparing base (71aef39) to head (b27f974).

Files with missing lines	Patch %	Lines
...otlin/com/wire/kalium/logic/data/id/QualifiedId.kt	0.00%	4 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3071   +/-   ##
========================================
  Coverage    52.68%   52.68%           
========================================
  Files         1318     1318           
  Lines        51133    51136    +3     
  Branches      4742     4743    +1     
========================================
+ Hits         26938    26940    +2     
- Misses       22269    22271    +2     
+ Partials      1926     1925    -1     

Files with missing lines	Coverage Δ
...otlin/com/wire/kalium/logic/data/id/QualifiedId.kt	0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71aef39...b27f974. Read the comment docs.

[datadog-wireapp]

Datadog Report

Branch report: fix/black-screen-when-last-user-group-kalium
Commit report: e01bce2
Test service: kalium-jvm

✅ 0 Failed, 3150 Passed, 106 Skipped, 33.35s Total Time

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

Bencher Report

Branch	fix/black-screen-when-last-user-group-kalium
Testbed	ubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

• Latency

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results

Benchmark	Latency	nanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles	📈 view plot ⚠️ NO THRESHOLD	662,427.72
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory	📈 view plot ⚠️ NO THRESHOLD	404,308,875.10
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark	📈 view plot ⚠️ NO THRESHOLD	927,954,900.93
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark	📈 view plot ⚠️ NO THRESHOLD	21,345,855.93

🐰 View full continuous benchmarking report in Bencher