Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update AVS lib to version 9.7.7 (WPB-6406) #2686

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

alexandreferris
Copy link
Contributor

@alexandreferris alexandreferris commented Mar 27, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Solutions

In version of AVS 9.7.+ we now have the function to send the original audio file and receive an almost the same audio file but with effects applied.

This is just updating AVS lib and other PRs will come into AR regarding audio effects.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@alexandreferris alexandreferris self-assigned this Mar 27, 2024
@alexandreferris alexandreferris requested review from a team, MohamadJaara, vitorhugods, mchenani, Garzas and saleniuk and removed request for a team March 27, 2024 07:33
Copy link
Contributor

github-actions bot commented Mar 27, 2024

Test Results

3 015 tests  ±0   2 894 ✔️ ±0   2m 28s ⏱️ -12s
   524 suites ±0      121 💤 ±0 
   524 files   ±0          0 ±0 

Results for commit 0608711. ± Comparison against base commit 99700d2.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Mar 27, 2024

Datadog Report

All test runs 2f4515d 🔗

2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Test Service View
kalium-ios 0 0 0 2764 127 7m 36.1s Link
kalium-jvm 0 0 0 2894 121 13m 48.05s Link

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.76%. Comparing base (99700d2) to head (0608711).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2686      +/-   ##
=============================================
- Coverage      58.77%   58.76%   -0.01%     
  Complexity         7        7              
=============================================
  Files           1201     1201              
  Lines          46836    46836              
  Branches        4395     4395              
=============================================
- Hits           27527    27523       -4     
- Misses         17343    17346       +3     
- Partials        1966     1967       +1     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99700d2...0608711. Read the comment docs.

@MohamadJaara MohamadJaara added this pull request to the merge queue Mar 27, 2024
Merged via the queue into develop with commit 409e685 Mar 27, 2024
20 checks passed
@MohamadJaara MohamadJaara deleted the chore/update_avs_version branch March 27, 2024 09:04
@echoes-hq echoes-hq bot added the echoes: features End-user visible changes intended to create customer value label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: features End-user visible changes intended to create customer value 👕 size: XS type: chore 🧹
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants