-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove architecture rule in CallRepository (WPB-6325) #2683
Conversation
Test Results2 150 tests - 862 2 137 ✔️ - 754 10s ⏱️ - 2m 52s Results for commit ca90758. ± Comparison against base commit 99c099c. This pull request removes 3012 and adds 2150 tests. Note that renamed tests count towards both.
This pull request removes 121 skipped tests and adds 13 skipped tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2683 +/- ##
=============================================
- Coverage 58.76% 58.75% -0.01%
Complexity 7 7
=============================================
Files 1201 1201
Lines 46836 46836
Branches 4396 4396
=============================================
- Hits 27522 27520 -2
- Misses 17347 17348 +1
- Partials 1967 1968 +1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
This rule is no longer needed after last changes on callRepository class
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.