Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unread self mention [WPB-5786] #2680

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  • updating edited message without self mention caused unread self mention

Causes (Optional)

  • unread mention badge on conversations

Solutions

  • fix check if mentions contains self user id

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

mention cases:

Case 1:

  1. send a new message with 2 ppl mentioned
  2. only the 2 ppl should see the icon
  3. edit the message to remove one mention
  4. only 1 person should see the icon

Case 2:

1 . send a message without a mention and then edit to add a mention and everyone will see the icon

@github-actions github-actions bot added the cherry-pick PR is cherry-picking changes from another banch label Mar 25, 2024
Copy link
Contributor Author

github-actions bot commented Mar 26, 2024

Test Results

15 tests   - 2 997   15 ✔️  - 2 876   4s ⏱️ - 2m 48s
  1 suites  -    523     0 💤  -    121 
  1 files    -    523     0 ±       0 

Results for commit 70a210c. ± Comparison against base commit 8b652ab.

This pull request removes 3012 and adds 15 tests. Note that renamed tests count towards both.
PocIntegrationTest ‑ givenApiWhenGettingACMEDirectoriesThenReturnAsExpectedBasedOnNetworkState
PocIntegrationTest ‑ givenEmailAndPasswordWhenLoggingInThenRegisterClientAndLogout
com.wire.kalium.HttpClientConnectionSpecsTest ‑ givenOkHttpSingleton_whenBuildingClearTextTrafficOkhttpClient_thenEnsureConnectionSpecClearText[jvm]
com.wire.kalium.HttpClientConnectionSpecsTest ‑ givenTheHttpClientIsCreated_ThenEnsureOnlySupportedSpecsArePresent[jvm]
com.wire.kalium.api.base.authenticated.notification.AccessUpdateTest ‑ givenPayloadWithAccessRoleAndDeprecatedAccessRoleField_whenDecoding_thenDeprecatedFieldIsPreferred[jvm]
com.wire.kalium.api.base.authenticated.notification.AccessUpdateTest ‑ givenPayloadWithDeprecatedAccessRoleField_whenDecoding_thenSuccess[jvm]
com.wire.kalium.api.base.authenticated.notification.AccessUpdateTest ‑ givenPayload_whenDecoding_thenSuccess[jvm]
com.wire.kalium.api.common.ACMEApiTest ‑ givenNoLocationInHeader_whenCallingSendAcmeRequestApi_theResponseShouldBeConfigureCorrectly[jvm]
com.wire.kalium.api.common.ACMEApiTest ‑ givenNoNonce_whenCallingSendAcmeRequestApi_theResponseShouldBeMissingNonce[jvm]
com.wire.kalium.api.common.ACMEApiTest ‑ givingASuccessfulResponse_whenGettingACMEFederationCertificateChain_thenAllCertificatesShouldBeParsed[jvm]
…
com.wire.kalium.logic.network.NetworkStateObserverImplTest ‑ givenBothNetworksConnectedWithInternetValidated_whenDefaultDisconnectsAndDefaultIsChanged_thenStateDoesNotChange
com.wire.kalium.logic.network.NetworkStateObserverImplTest ‑ givenBothNetworksConnectedWithInternetValidated_whenDefaultNetworkChanges_thenStateDoesNotChange
com.wire.kalium.logic.network.NetworkStateObserverImplTest ‑ givenBothNetworksConnectedWithInternetValidated_whenOtherDisconnects_thenStateDoesNotChange
com.wire.kalium.logic.network.NetworkStateObserverImplTest ‑ givenNoNetworkConnected_thenStateIsNotConnected
com.wire.kalium.logic.network.NetworkStateObserverImplTest ‑ givenNoNetworkConnected_whenOneConnectsWithInternetValidated_thenStateChangesToConnectedWithInternet
com.wire.kalium.logic.network.NetworkStateObserverImplTest ‑ givenNoNetworkConnected_whenOneConnectsWithoutInternetValidated_thenStateChangesToConnectedWithoutInternet
com.wire.kalium.logic.network.NetworkStateObserverImplTest ‑ givenOneNetworkConnectedWithInternetValidatedButBlocked_whenItChangesToNotBlocked_thenStateChangesToConnectedWithInternet
com.wire.kalium.logic.network.NetworkStateObserverImplTest ‑ givenOneNetworkConnectedWithInternetValidated_thenStateIsConnectedWithInternet
com.wire.kalium.logic.network.NetworkStateObserverImplTest ‑ givenOneNetworkConnectedWithInternetValidated_whenItChangesToBlocked_thenStateChangesToConnectedWithoutInternet
com.wire.kalium.logic.network.NetworkStateObserverImplTest ‑ givenOneNetworkConnectedWithInternetValidated_whenItDisconnects_thenStateChangesToNotConnected
…

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Mar 26, 2024

Datadog Report

All test runs 095655d 🔗

2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Test Service View
kalium-ios 0 0 0 2543 73 5m 3.11s Link
kalium-jvm 0 0 0 2894 121 13m 13.01s Link

@MohamadJaara MohamadJaara added this pull request to the merge queue Mar 26, 2024
Merged via the queue into develop with commit 99700d2 Mar 26, 2024
17 checks passed
@MohamadJaara MohamadJaara deleted the fix/unread-self-mention-cherry-pick branch March 26, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch 👕 size: M type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants