-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove CRL check for current client (WPB-7125) #2658
fix: remove CRL check for current client (WPB-7125) #2658
Conversation
…or_current_client-cherry-pick # Conflicts: # logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/e2ei/usecase/CheckRevocationListUseCase.kt
Test Results2 591 tests - 393 2 576 ✔️ - 287 4m 25s ⏱️ + 1m 19s Results for commit bd709a7. ± Comparison against base commit 824eb8b. This pull request removes 2984 and adds 2591 tests. Note that renamed tests count towards both.
This pull request removes 121 skipped tests and adds 15 skipped tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2658 +/- ##
==========================================
Coverage 58.76% 58.76%
Complexity 7 7
==========================================
Files 1189 1188 -1
Lines 46307 46269 -38
Branches 4380 4373 -7
==========================================
- Hits 27212 27190 -22
+ Misses 17144 17129 -15
+ Partials 1951 1950 -1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Cherry pick from the original PR:
logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/e2ei/usecase/CheckRevocationListUseCase.kt
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
We don't need to check CRL for self separatly by getting url from userConfig. CC is already returning the crl for self client
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References