Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MLS enabling setting [WPB-7097] #2643

Merged
merged 8 commits into from
Mar 13, 2024

Conversation

borichellow
Copy link
Contributor

@borichellow borichellow commented Mar 13, 2024

What's new in this PR?

Issues

Wrong calculating if MLS is enabled for user or not.

Causes (Optional)

Nobody knows how it should work :)

Solutions

Fix it:

  • if the MLS is enabled in settings AND MLS is in the supported protocols list,
  • in all other cases MLS is disabled.

AND
in com.wire.kalium.logic.data.featureConfig.MLSModel make field allowedUsers nullable as it might be removed in the future.

Copy link
Contributor

github-actions bot commented Mar 13, 2024

Test Results

2 844 tests   2 715 ✔️  23s ⏱️
   486 suites     129 💤
   486 files           0

Results for commit 1cc46b4.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Mar 13, 2024

Datadog Report

Branch report: fix/mls_enabling_setting
Commit report: b360b66
Test service: kalium-jvm

✅ 0 Failed, 2845 Passed, 123 Skipped, 8m 56.04s Wall Time

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release/candidate@cfceb4a). Click here to learn what that means.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             release/candidate    #2643   +/-   ##
====================================================
  Coverage                     ?   58.34%           
  Complexity                   ?        7           
====================================================
  Files                        ?     1177           
  Lines                        ?    46181           
  Branches                     ?     4387           
====================================================
  Hits                         ?    26946           
  Misses                       ?    17273           
  Partials                     ?     1962           
Files Coverage Δ
...ium/logic/data/featureConfig/FeatureConfigModel.kt 100.00% <100.00%> (ø)
.../feature/featureConfig/handler/MLSConfigHandler.kt 100.00% <100.00%> (ø)
...henticated/featureConfigs/FeatureConfigResponse.kt 83.52% <100.00%> (ø)
...n/kotlin/com/wire/kalium/logic/data/event/Event.kt 77.31% <0.00%> (ø)
...um/logic/data/featureConfig/FeatureConfigMapper.kt 68.42% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfceb4a...57d978a. Read the comment docs.

@ohassine ohassine enabled auto-merge (squash) March 13, 2024 15:48
@ohassine ohassine merged commit 9233d5f into release/candidate Mar 13, 2024
17 checks passed
@ohassine ohassine deleted the fix/mls_enabling_setting branch March 13, 2024 16:33
@echoes-hq echoes-hq bot added the echoes: bugs Technical or functional defects in the product label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants