-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: MLS enabling setting [WPB-7097] #2643
Conversation
...otlin/com/wire/kalium/network/api/base/authenticated/featureConfigs/FeatureConfigResponse.kt
Outdated
Show resolved
Hide resolved
logic/src/commonMain/kotlin/com/wire/kalium/logic/data/featureConfig/FeatureConfigModel.kt
Outdated
Show resolved
Hide resolved
Datadog ReportBranch report: ✅ 0 Failed, 2845 Passed, 123 Skipped, 8m 56.04s Wall Time |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #2643 +/- ##
====================================================
Coverage ? 58.34%
Complexity ? 7
====================================================
Files ? 1177
Lines ? 46181
Branches ? 4387
====================================================
Hits ? 26946
Misses ? 17273
Partials ? 1962
Continue to review full report in Codecov by Sentry.
|
What's new in this PR?
Issues
Wrong calculating if MLS is enabled for user or not.
Causes (Optional)
Nobody knows how it should work :)
Solutions
Fix it:
AND
in
com.wire.kalium.logic.data.featureConfig.MLSModel
make fieldallowedUsers
nullable as it might be removed in the future.