fix: handle with scheme and domain from corecrypto [WPB-7084] #2626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
the
cherry-pick
|
should be fixed and merged after this one: #2603 |
7 tasks
…heme_and_domain_from_corecrypto-cherry-pick # Conflicts: # logic/src/commonMain/kotlin/com/wire/kalium/logic/data/e2ei/MLSConversationsVerificationStatusesHandler.kt
Test Results2 194 tests - 789 2 131 ✔️ - 731 18s ⏱️ - 2m 15s Results for commit 261b87e. ± Comparison against base commit 803abb6. This pull request removes 2983 and adds 2194 tests. Note that renamed tests count towards both.This pull request removes 121 skipped tests and adds 63 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
saleniuk
requested review from
a team,
typfel,
yamilmedina,
borichellow,
Garzas and
e-lisa
and removed request for
a team
saleniuk
requested review from
a team,
alexandreferris and
vitorhugods
and removed request for
typfel,
yamilmedina,
e-lisa and
a team
…recrypto-cherry-pick
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2626 +/- ##
==========================================
Coverage 58.76% 58.77%
Complexity 7 7
==========================================
Files 1189 1189
Lines 46313 46314 +1
Branches 4380 4380
==========================================
+ Hits 27218 27221 +3
Misses 17143 17143
+ Partials 1952 1950 -2
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
saleniuk
approved these changes
Mar 15, 2024
alexandreferris
approved these changes
Mar 15, 2024
…heme_and_domain_from_corecrypto-cherry-pick # Conflicts: # cryptography/src/commonMain/kotlin/com/wire/kalium/cryptography/IDs.kt
saleniuk
deleted the
fix/handle_with_scheme_and_domain_from_corecrypto-cherry-pick
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick from the original PR:
cryptography/src/commonMain/kotlin/com/wire/kalium/cryptography/IDs.kt
logic/src/commonMain/kotlin/com/wire/kalium/logic/data/e2ei/MLSConversationsVerificationStatusesHandler.kt
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
When getting user identities from core crypto, field has a different format because it contains also scheme and domain.
Solutions
Provide another property that returns only the core handle without scheme, at sign and domain.
Testing
Test Coverage (Optional)
How to Test
Create a new MLS group with all users verified - it should have a badge.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References