-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle with scheme and domain from corecrypto [WPB-7084] #2626
fix: handle with scheme and domain from corecrypto [WPB-7084] #2626
Conversation
should be fixed and merged after this one: #2603 |
…heme_and_domain_from_corecrypto-cherry-pick # Conflicts: # logic/src/commonMain/kotlin/com/wire/kalium/logic/data/e2ei/MLSConversationsVerificationStatusesHandler.kt
Test Results2 194 tests - 789 2 131 ✔️ - 731 18s ⏱️ - 2m 15s Results for commit 261b87e. ± Comparison against base commit 803abb6. This pull request removes 2983 and adds 2194 tests. Note that renamed tests count towards both.
This pull request removes 121 skipped tests and adds 63 skipped tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
…recrypto-cherry-pick
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2626 +/- ##
==========================================
Coverage 58.76% 58.77%
Complexity 7 7
==========================================
Files 1189 1189
Lines 46313 46314 +1
Branches 4380 4380
==========================================
+ Hits 27218 27221 +3
Misses 17143 17143
+ Partials 1952 1950 -2
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…heme_and_domain_from_corecrypto-cherry-pick # Conflicts: # cryptography/src/commonMain/kotlin/com/wire/kalium/cryptography/IDs.kt
Cherry pick from the original PR:
cryptography/src/commonMain/kotlin/com/wire/kalium/cryptography/IDs.kt
logic/src/commonMain/kotlin/com/wire/kalium/logic/data/e2ei/MLSConversationsVerificationStatusesHandler.kt
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
When getting user identities from core crypto, field has a different format because it contains also scheme and domain.
Solutions
Provide another property that returns only the core handle without scheme, at sign and domain.
Testing
Test Coverage (Optional)
How to Test
Create a new MLS group with all users verified - it should have a badge.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References