Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cert pinning failing for GET:/api-version #2301

Merged

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

cert pinning failing for GET:/api-version only

Solutions

there is a flag to ignore ssl cert in unbound network client for e2ei and that flag should be true only in debug mode and it was not, it should not have effected any users in prod

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@MohamadJaara MohamadJaara enabled auto-merge (squash) December 11, 2023 10:46
Copy link
Contributor

github-actions bot commented Dec 11, 2023

Unit Test Results

   445 files     445 suites   20s ⏱️
2 517 tests 2 398 ✔️ 119 💤 0

Results for commit 78e5c02.

♻️ This comment has been updated with latest results.

@MohamadJaara MohamadJaara merged commit 7c7fd92 into release/candidate Dec 11, 2023
18 checks passed
@MohamadJaara MohamadJaara deleted the fix/cert-pnning-for-api-version-endpoint branch December 11, 2023 11:04
github-merge-queue bot pushed a commit that referenced this pull request Dec 14, 2023
Co-authored-by: Mohamad Jaara <mohamad.jaara@wire.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants