fix(RC): self clients list is not updated when a new client event is received (WPB-5791) #2290 #2293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borichellow
requested review from
typfel,
alexandreferris,
MohamadJaara,
mchenani,
agisilaos and
ohassine
MohamadJaara
approved these changes
Dec 7, 2023
MohamadJaara
changed the title
mchenani
approved these changes
Dec 7, 2023
yamilmedina
approved these changes
Dec 7, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #2293 +/- ##
====================================================
Coverage ? 58.08%
Complexity ? 21
====================================================
Files ? 1073
Lines ? 40789
Branches ? 3782
====================================================
Hits ? 23691
Misses ? 15477
Partials ? 1621 Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ |
MohamadJaara
deleted the
release/fix/end_calls_when_self_added_new_device
branch
echoes-hq
bot
added
the
echoes: features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
Issues
When I'm on a call in Proteus-verified conversation and I add a new client (login on new device). Conversation should degrade the verification status and end a call.
Causes (Optional)
a
NewClientEventhandler doesn't save a new Client into the Client DB table, so the trigger for re-checking the conversation verification is not called -> conversation doesn't degrade -> call is not ended.Solutions
Save new client into Client DB table on every
NewClientEvent.Develop PR copy