-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(RC): self clients list is not updated when a new client event is received (WPB-5791) #2290 #2293
fix(RC): self clients list is not updated when a new client event is received (WPB-5791) #2290 #2293
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #2293 +/- ##
====================================================
Coverage ? 58.08%
Complexity ? 21
====================================================
Files ? 1073
Lines ? 40789
Branches ? 3782
====================================================
Hits ? 23691
Misses ? 15477
Partials ? 1621 Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ |
What's new in this PR?
Issues
When I'm on a call in Proteus-verified conversation and I add a new client (login on new device). Conversation should degrade the verification status and end a call.
Causes (Optional)
a
NewClientEvent
handler doesn't save a new Client into the Client DB table, so the trigger for re-checking the conversation verification is not called -> conversation doesn't degrade -> call is not ended.Solutions
Save new client into Client DB table on every
NewClientEvent
.Develop PR copy