-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fetch full list of team members when kalium consumers needs to #2284
feat: fetch full list of team members when kalium consumers needs to #2284
Conversation
Test Results1 895 tests - 782 1 865 ✔️ - 708 10s ⏱️ - 2m 25s Results for commit 3353242. ± Comparison against base commit 8e02923. This pull request removes 2677 and adds 1895 tests. Note that renamed tests count towards both.
This pull request removes 104 skipped tests and adds 30 skipped tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2284 +/- ##
=============================================
+ Coverage 57.87% 57.89% +0.01%
Complexity 21 21
=============================================
Files 1093 1093
Lines 41359 41392 +33
Branches 3816 3820 +4
=============================================
+ Hits 23938 23965 +27
- Misses 15811 15815 +4
- Partials 1610 1612 +2
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
logic/src/commonMain/kotlin/com/wire/kalium/logic/data/team/TeamRepository.kt
Outdated
Show resolved
Hide resolved
logic/src/commonMain/kotlin/com/wire/kalium/logic/data/team/TeamRepository.kt
Outdated
Show resolved
Hide resolved
Datadog ReportAll test runs ❌ 2 Total Test Services: 2 Failed, 0 with New Flaky, 0 Passed Test Services
❌ Failed Tests (2)
|
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
some consumers of kalium like Infinite Monkeys expect a full list of team members to be stored locally
Solutions
Add a flag on KaliumConfigs called fetchAllTeamMembersEagerly (false by default).
This flag, if true would actually fetch all team members in a paginated fashion during slow sync.
If false, it keeps the current behaviour of only fetching users with established connection + other people that are members of the same conversations as self user.
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.