-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable editable app lock toggle (WPB-5610) #2262
fix: enable editable app lock toggle (WPB-5610) #2262
Conversation
… data not found for first time (#2258)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2262 +/- ##
=============================================
- Coverage 57.93% 57.92% -0.01%
Complexity 21 21
=============================================
Files 1085 1085
Lines 41090 41090
Branches 3806 3806
=============================================
- Hits 23805 23802 -3
- Misses 15657 15659 +2
- Partials 1628 1629 +1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
* fix: enable editable app lock toggle when there is storage failure as data not found for first time (#2258) * empty trigger commit --------- Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> Co-authored-by: Yamil Medina <yamilmedina@users.noreply.github.com>
Cherry pick from the original PR:
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
When private users started the app there was no value from and was always returning thus not enabling the user to toggle in settings
Solutions
Invert the value provided from the in the usecase
Testing
How to Test
Testing will be available in AR PR.