fix: enable editable app lock toggle (WPB-5610) #2262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
… data not found for first time (#2258)
github-actions
bot
added
the
cherry-pick
alexandreferris
requested review from
a team,
yamilmedina,
borichellow,
MohamadJaara,
mchenani and
ohassine
and removed request for
a team
github-actions
bot
added
🚨 Potential breaking changes
type: bug / fix 🐞
👕 size: XS
labels
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2262 +/- ##
=============================================
- Coverage 57.93% 57.92% -0.01%
Complexity 21 21
=============================================
Files 1085 1085
Lines 41090 41090
Branches 3806 3806
=============================================
- Hits 23805 23802 -3
- Misses 15657 15659 +2
- Partials 1628 1629 +1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
yamilmedina
approved these changes
Nov 26, 2023
mchenani
approved these changes
Nov 27, 2023
augustocdias
pushed a commit
that referenced
this pull request
Dec 5, 2023
* fix: enable editable app lock toggle when there is storage failure as data not found for first time (#2258) * empty trigger commit --------- Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> Co-authored-by: Yamil Medina <yamilmedina@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick from the original PR:
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
When private users started the app there was no value from and was always returning thus not enabling the user to toggle in settings
Solutions
Invert the value provided from the in the usecase
Testing
How to Test
Testing will be available in AR PR.