feat(monkeys): Interact with "external" users from the test [WPB-5129] #2219

augustocdias · 2023-11-13T12:01:01Z

PR Submission Checklist for internal contributors

The PR Title
- conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- contains a reference JIRA issue number like SQPIT-764
- answers the question: If merged, this PR will: ... ³
The PR Description
- is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

This adds 2 more actions to IM to accept and send connection request to users outside of the monkeys scope. Sending messages, adding to groups is already supported as long as monkeys and users are known to each other.

As discussed in #2172, unit tests are being removed in favour of e2e tests to be added later.

References

https://sparkbox.com/foundry/semantic_commit_messages
https://github.com/wireapp/.github#usage
E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

github-actions · 2023-11-13T12:24:01Z

Unit Test Results

  475 files +  3   475 suites +3 2m 39s ⏱️ -23s
2 649 tests +12 2 545 ✔️ +12 104 💤 ±0 0 ❌ ±0

Results for commit a6a7bd8. ± Comparison against base commit 35c87b5.

♻️ This comment has been updated with latest results.

codecov-commenter · 2023-11-14T08:55:00Z

Codecov Report

Merging #2219 (f000285) into develop (1ad916c) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

@@              Coverage Diff              @@
##             develop    #2219      +/-   ##
=============================================
- Coverage      57.90%   57.90%   -0.01%     
  Complexity        21       21              
=============================================
  Files           1093     1093              
  Lines          41394    41394              
  Branches        3820     3820              
=============================================
- Hits           23969    23968       -1     
- Misses         15813    15814       +1     
  Partials        1612     1612

see 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ad916c...f000285. Read the comment docs.

datadog-wireapp · 2023-11-14T08:56:25Z

Datadog Report

Branch report: feat/monkeys/playtest-interact
Commit report: e96781f

✅ kalium-jvm: 0 Failed, 0 New Flaky, 2531 Passed, 104 Skipped, 7m 24.01s Wall Time

datadog-wireapp · 2023-11-21T13:57:47Z

Datadog Report

Branch report: feat/monkeys/playtest-interact
Commit report: 9317a27

✅ kalium-jvm: 0 Failed, 0 New Flaky, 2545 Passed, 104 Skipped, 7m 16.06s Wall Time

vitorhugods

LGTM.

I just think that inMemoryStorage can be used again now that it supports login and logout.

vitorhugods · 2023-12-04T20:44:19Z

monkeys/src/main/kotlin/com/wire/kalium/monkeys/actions/SendMessageAction.kt

+    """
+        Hey there,
+
+        I'm really in the mood for some bananas, and I was wondering if you could lend a hand. I'd truly appreciate it. Bananas have a 
+        special place in my heart, and your help would brighten my day.
+
+        Thanks for thinking it over.
+    """,
+    """
+        Hey,
+
+        I've got a hankering for some bananas. Any chance you could help me out?
+
+        Appreciate it!
+    """,
+    """
+        Hello,
+
+        I'm on the hunt for bananas, and I'm reaching out to see if you or your group could assist. Your help would mean a lot to me.
+
+        Thanks in advance.
+    """,
+    """
+        Hey,
+
+        I've got this banana craving that won't quit. Can you come to the rescue?
+
+        Much appreciated!
+    """,
+    """
+        Hi there,
+
+        I'm in need of some bananas, and I'm wondering if you or your group could lend a hand. Your support would make my day.
+
+        Thanks a bunch!  
+    """,
+    """
+        Hello,
+
+        I'm really feeling the banana vibe right now. Could you or your group be the banana heroes I'm looking for?
+
+        Thanks in advance.
+    """,
+    """
+       Hey,
+
+       Bananas are calling my name. Any chance you can help satisfy my fruity desires?
+
+       Thanks a bunch! 
+    """,
+    """
+       Hi,
+
+       I'm on a mission to find bananas, and I'm hoping you or your group can assist. Your kindness would be greatly appreciated.
+
+       Thanks for considering. 
+    """,
+    """
+       Hey there,
+
+       I've got a strong craving for bananas. Could you lend a hand in satisfying it?
+
+       Many thanks! 
+    """,
+    """
+       Hello,
+
+       I'm in the mood for some bananas. Can you or your group help me out? It would mean a lot.
+
+       Thanks in advance! 
+    """,
+    """
+       Hey,
+
+       I've got this banana hankering that won't quit. Can you be the banana hero I need?
+
+       Much appreciated! 


vitorhugods · 2023-12-04T20:44:59Z

monkeys/src/main/kotlin/com/wire/kalium/monkeys/actions/HandleExternalRequestAction.kt

+        Hey there,
+
+        I hope you're doing well. I've got a bit of a craving for bananas, and I was wondering if you might be able to share a few with me? 
+        It would mean a lot. 😊
+
+        Thanks a bunch,
+        A friendly monkey 🍌🐵
+    """.trimIndent(), """
+        Yo,
+
+        I'm in need of some bananas, my friend. Can you hook me up? I'd appreciate it big time.
+
+        Respect,
+        A neutral monkey 🍌
+    """.trimIndent(), """
+        Listen up,
+
+        I ain't messin' around. I want them bananas, and I want 'em now. You better deliver or there'll be consequences.
+
+        No games,
+        An evil monkey 🍌👿💀


This is too good.

All AI generated 🤣

vitorhugods · 2023-12-04T20:46:58Z

monkeys/src/main/kotlin/com/wire/kalium/monkeys/homeDirectory.kt

            developmentApiEnabled = true,
            encryptProteusStorage = true,
            isMLSSupportEnabled = true,
            wipeOnDeviceRemoval = true,
-        ), "Wire Infinite Monkeys"
+        ), userAgent = "Wire Infinite Monkeys", useInMemoryStorage = false


I think you can use inMemoryStorage = true now. After

fix(jvm): support logout and login when using in-memory storage #2274

I'll enable it again :) Forgot to push

github-actions · 2023-12-05T07:53:06Z

Test Results

2 682 tests ±0 2 578 ✔️ ±0 2m 34s ⏱️ +16s
  480 suites ±0   104 💤 ±0
  480 files ±0       0 ❌ ±0

Results for commit f000285. ± Comparison against base commit 1ad916c.

♻️ This comment has been updated with latest results.

datadog-wireapp · 2023-12-05T08:08:05Z

Datadog Report

Branch report: feat/monkeys/playtest-interact
Commit report: 4db23e0

✅ kalium-jvm: 0 Failed, 0 New Flaky, 2578 Passed, 104 Skipped, 7m 22s Wall Time

typfel · 2023-12-06T13:34:11Z

monkeys/src/main/kotlin/com/wire/kalium/monkeys/pool/MonkeyPool.kt

+        // this is needed to create key packages for clients at least once
+        poolById.values.map {
+            async {
+                it.login(core) {}
+                it.logout {}
+            }
+        }.awaitAll()
+    }


Do you have ticket for this bug? Let's add reference to it here

augustocdias requested review from vitorhugods and typfel November 13, 2023 12:01

github-actions bot assigned augustocdias Nov 13, 2023

github-actions bot added type: feature ✨ 👕 size: XXL 👕 size: XL and removed 👕 size: XXL labels Nov 13, 2023

github-actions bot added 👕 size: XXL and removed 👕 size: XL labels Nov 15, 2023

augustocdias force-pushed the feat/monkeys/playtest-interact branch 2 times, most recently from d042c1c to acd2492 Compare November 21, 2023 13:39

augustocdias requested review from typfel and vitorhugods and removed request for typfel and vitorhugods November 30, 2023 10:41

vitorhugods approved these changes Dec 4, 2023

View reviewed changes

augustocdias force-pushed the feat/monkeys/playtest-interact branch from 429471c to 8441425 Compare December 5, 2023 07:47

feat(monkeys): Interact with "external" users from the test [WPB-5129]

f000285

augustocdias force-pushed the feat/monkeys/playtest-interact branch from 8441425 to f000285 Compare December 6, 2023 09:08

typfel reviewed Dec 6, 2023

View reviewed changes

typfel approved these changes Dec 6, 2023

View reviewed changes

augustocdias added this pull request to the merge queue Dec 6, 2023

Merged via the queue into develop with commit 4e75095 Dec 6, 2023
17 checks passed

augustocdias deleted the feat/monkeys/playtest-interact branch December 6, 2023 14:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(monkeys): Interact with "external" users from the test [WPB-5129] #2219

feat(monkeys): Interact with "external" users from the test [WPB-5129] #2219

augustocdias commented Nov 13, 2023

github-actions bot commented Nov 13, 2023 •

edited

Loading

codecov-commenter commented Nov 14, 2023 •

edited

Loading

datadog-wireapp bot commented Nov 14, 2023 •

edited

Loading

datadog-wireapp bot commented Nov 21, 2023 •

edited

Loading

vitorhugods left a comment

vitorhugods Dec 4, 2023

vitorhugods Dec 4, 2023

augustocdias Dec 5, 2023

vitorhugods Dec 4, 2023

augustocdias Dec 5, 2023

github-actions bot commented Dec 5, 2023 •

edited

Loading

datadog-wireapp bot commented Dec 5, 2023 •

edited

Loading

typfel Dec 6, 2023

feat(monkeys): Interact with "external" users from the test [WPB-5129] #2219

feat(monkeys): Interact with "external" users from the test [WPB-5129] #2219

Conversation

augustocdias commented Nov 13, 2023

PR Submission Checklist for internal contributors

What's new in this PR?

References

github-actions bot commented Nov 13, 2023 • edited Loading

Unit Test Results

codecov-commenter commented Nov 14, 2023 • edited Loading

Codecov Report

datadog-wireapp bot commented Nov 14, 2023 • edited Loading

Datadog Report

datadog-wireapp bot commented Nov 21, 2023 • edited Loading

Datadog Report

vitorhugods left a comment

Choose a reason for hiding this comment

vitorhugods Dec 4, 2023

Choose a reason for hiding this comment

vitorhugods Dec 4, 2023

Choose a reason for hiding this comment

augustocdias Dec 5, 2023

Choose a reason for hiding this comment

vitorhugods Dec 4, 2023

Choose a reason for hiding this comment

augustocdias Dec 5, 2023

Choose a reason for hiding this comment

github-actions bot commented Dec 5, 2023 • edited Loading

Test Results

datadog-wireapp bot commented Dec 5, 2023 • edited Loading

Datadog Report

typfel Dec 6, 2023

Choose a reason for hiding this comment

github-actions bot commented Nov 13, 2023 •

edited

Loading

codecov-commenter commented Nov 14, 2023 •

edited

Loading

datadog-wireapp bot commented Nov 14, 2023 •

edited

Loading

datadog-wireapp bot commented Nov 21, 2023 •

edited

Loading

github-actions bot commented Dec 5, 2023 •

edited

Loading

datadog-wireapp bot commented Dec 5, 2023 •

edited

Loading