refactor: crypto-ffi: statically link the runtime lib via Makefile.toml [WPB-8945] #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Please elaborate. This was added as android x86 was crashing due to missing clang libs during runtime. See: |
istankovic
force-pushed
the
remove-explicit-link-clang-rt-builtins
branch
from
14ab6ef
to
48dbcbe
Compare
istankovic
changed the title
@vitorhugods could you please try the updated branch here? |
istankovic
changed the title
…ml [WPB-8945] On Android x86-64 we need to link the runtime lib statically because the compiler fails to do so due to -nodefaultlibs being given by default. This is not a problem on other Android platforms, though. More details at mozilla/application-services#5436
istankovic
force-pushed
the
remove-explicit-link-clang-rt-builtins
branch
from
48dbcbe
to
0798f7c
Compare
|
@typfel said it worked for him. |
I trust him more than I trust myself. |
augustocdias
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Android x86-64 we need to link the runtime lib statically because
the compiler fails to do so due to -nodefaultlibs being given by
default. This is not a problem on other Android platforms, though.
More details at mozilla/application-services#5436