Skip to content

Fix direct navigation to JS-based sub menu items #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LukeTowers wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix direct navigation to JS-based sub menu items #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions assets/dist/assets/app-BE5rH6M-.js
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions assets/dist/assets/app-BhipQWM7.css
View file
Open in desktop

Large diffs are not rendered by default.

11 changes: 0 additions & 11 deletions assets/dist/assets/app-CJKaKl1c.js
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion assets/dist/assets/app-Rg3cM_by.css
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions assets/dist/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{
"assets/src/css/app.css": {
"file": "assets/app-Rg3cM_by.css",
"file": "assets/app-BhipQWM7.css",
"src": "assets/src/css/app.css",
"isEntry": true
},
"assets/src/js/app.js": {
"file": "assets/app-CJKaKl1c.js",
"file": "assets/app-BE5rH6M-.js",
"name": "app",
"src": "assets/src/js/app.js",
"isEntry": true
Expand Down
17 changes: 17 additions & 0 deletions assets/src/js/winter.sidepaneltab.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,23 @@
this.visibleItemId = false
this.$fixButton = $('<a href="#" class="fix-button"><i class="icon-thumb-tack"></i></a>')

// Check for a targeted side menu item on page load
if (location.hash.startsWith('#menu-item-')) {
const parts = location.hash.substring(1).split('-');
const menuCode = parts[2];
if (menuCode === this.$el.data('menu-code')) {
const itemId = location.hash.substring(('#menu-item-' + menuCode + '-child-').length);
const $targetItem = self.$sideNavItems.filter('[data-menu-item="' + itemId + '"]');
if ($targetItem.length) {
this.$sideNavItems.toggleClass('active', false);
self.displaySidePanel();
self.displayTab($targetItem);
$targetItem.addClass('active');
history.replaceState(null, null, ' ');
}
}
}

this.$fixButton.click(function() {
self.fixPanel()
return false
Expand Down
5 changes: 3 additions & 2 deletions skins/tailwindui/layouts/partials/menu/side/_item-contents.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ class="w-4 h-4"
<?php endif; ?>
</div>
<?php if ($hasChildren) : ?>
<?php $itemFullCode = $item->owner . '.' . $item->code; ?>
<nav
class="sidemenu-item-child
<?php if ($itemMode === 'inline') : ?>
Expand All @@ -86,7 +87,7 @@ class="sidemenu-item-child
<?php endif; ?>
"
id="<?= $item->code ?>"
data-menu-code="<?= $item->owner . '.' . $item->code; ?>"
data-menu-code="<?= $itemFullCode; ?>"
data-control="sidenav"
data-active-class="active"
>
Expand All @@ -102,7 +103,7 @@ class="<?= $sideMenuIsActive ? 'active' : '' ?> relative"
<?php if ($child->url === 'javascript:;'): ?>data-menu-item="<?= $child->code ?>"<?php endif; ?>
>
<a
href="<?= $child->url === 'javascript:;' ? "$item->url" : $child->url ?>"
href="<?= $child->url === 'javascript:;' ? "$item->url#menu-item-{$itemFullCode}-child-{$child->code}" : $child->url ?>"
class="
group w-full flex items-center py-1.5
text-sm text-white font-medium rounded-md hover:text-white
Expand Down