winter 1.2.8 support #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
LukeTowers
reviewed
May 6, 2025
Comment on lines
111
to
117
| public function create() | ||
| { | ||
| $this->formLayout = 'sidebar'; | ||
|
|
||
| parent::create(); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Why is this required if we're already setting the formLayout to sidebar by default?
Member
Author
There was a problem hiding this comment.
It was meant to be 'standard' in create context... I commited a fix.
LukeTowers
reviewed
May 6, 2025
LukeTowers
approved these changes
Jun 4, 2025
Member
LukeTowers
left a comment
LukeTowers
left a comment
There was a problem hiding this comment.
Approved pending merge of wintercms/winter#1312 and release of Winter v1.2.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on wintercms/winter#1312
Update Winter.Redirect to use formcontroller behavior's default views.