Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix for colorpicker hex with alpha saving #1318

Merged
merged 3 commits into from
Feb 26, 2025

Conversation

jaxwilko
Copy link
Member

Should fix #1316 (comment).

I tested all supported formats (cmyk, hex, hsl, rgb) with and without showAlpha: true and they all save correctly.

@jaxwilko jaxwilko requested a review from mjauvin February 26, 2025 14:31
@mjauvin
Copy link
Member

mjauvin commented Feb 26, 2025

Looks good to me.

@lex0r can you test this and let us know if that resolves the issue?

@LukeTowers LukeTowers added the maintenance PRs that fix bugs, are translation changes or make only minor changes label Feb 26, 2025
@LukeTowers LukeTowers added this to the 1.2.8 milestone Feb 26, 2025
@LukeTowers LukeTowers merged commit 85f05e7 into develop Feb 26, 2025
11 checks passed
@LukeTowers LukeTowers deleted the fix/colorpicker-hex-alpha branch February 26, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance PRs that fix bugs, are translation changes or make only minor changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Colorpicker value never passes validation with showAlpha = true
3 participants