Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid Vite generating an extra assets folder in assets/dist #1264

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Avoid Vite generating an extra assets folder in assets/dist #1264

merged 1 commit into from
Dec 4, 2024

Conversation

damsfx
Copy link
Contributor

@damsfx damsfx commented Dec 4, 2024 •
edited
Loading

Before :

themes/mytheme
├─ assets/
│  ├─ dist/
│  │  ├─ assets/
│  │  │  ├─ mytheme-xxxxx.js
│  │  │  ├─ mytheme-xxxxx.css
│  │  ├─ manifest.json
│  ├─ src/
│  │  ├─ css/
│  │  │  ├─ mytheme.css
│  │  ├─ js/
│  │  │  ├─mytheme.js
│  ├─ manifest.json

After :

themes/mytheme
├─ assets/
│  ├─ dist/
│  │  ├─ mytheme-xxxxx.js
│  │  ├─ mytheme-xxxxx.css
│  │  ├─ manifest.json
│  ├─ src/
│  │  ├─ css/
│  │  │  ├─ mytheme.css
│  │  ├─ js/
│  │  │  ├─ mytheme.js
│  ├─ manifest.json

@LukeTowers LukeTowers added the maintenance PRs that fix bugs, are translation changes or make only minor changes label Dec 4, 2024
jaxwilko
jaxwilko approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@jaxwilko jaxwilko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally.

@LukeTowers LukeTowers merged commit d3b2ccb into wintercms:develop Dec 4, 2024
12 checks passed
@LukeTowers LukeTowers added this to the 1.2.7 milestone Dec 4, 2024
@damsfx damsfx deleted the fix-vite-outputdir branch December 5, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaxwilko jaxwilko jaxwilko approved these changes

Assignees
No one assigned
Labels
maintenance PRs that fix bugs, are translation changes or make only minor changes
Projects
None yet
Milestone
1.2.7
Development

Successfully merging this pull request may close these issues.
3 participants
@damsfx @jaxwilko @LukeTowers