Support project relative paths to sqlite databases regardless of webroot #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukeTowers
changed the title
taylorotwell
added a commit
to laravel/framework
that referenced
this pull request
Feb 6, 2025
* Support relative paths to SQLite databases Related: #45626, wintercms/storm#191 * Styling * Update SQLiteConnector.php --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
taylorotwell
added a commit
to illuminate/database
that referenced
this pull request
Feb 6, 2025
* Support relative paths to SQLite databases Related: laravel/framework#45626, wintercms/storm#191 * Styling * Update SQLiteConnector.php --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
|
@LukeTowers should we revert this in the Laravel 11 branch since the fix has been merged upstream? |
|
@mjauvin yes please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows setting SQLite db path relative to app root, even when running with mirrored install.