Conversation
|
I agree that there should be a command to return the raw Composer response. Ideally, the raw response should be stored in the Command instance and be accessible through a method, so the likely candidate for this would be the Command abstract. Worth pursuing in another PR. |
bennothommo
left a comment
There was a problem hiding this comment.
Actually, scratch the previous approval, will need to either update the tests or make sure they pass :)
Yeah i think that would be perfect, i'll do a little tinkering and see if i can provide a consitant |
This PR adds additional options to existing commands and adds additional commands.
It's a merge of the functionality added in the storm extension here: wintercms/storm#197
Note
For the
searchcommand I've added areturnArrayoption, I don't remember why exsactly, but I believe some information was returned by composer but lost when cast to custom objects. Not 100% sure it's even still in use in the Winter PR so maybe worth removing (i'll review with fresh eyes in the coming days).However, it maybe nice to have a more consistant method for returning the raw data from composer, thoughts?