Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib): File Transports Not Emitting Errors On Stream Errors #581

Closed
wants to merge 5 commits into from

Commits on Mar 16, 2015

  1. fix(lib): File Transports Not Emitting Errors On Stream Errors

    In this commit file & daily-rotate-file add an 'error' event listener on
    their stream so that we can emit those errors from the transport.
    
    fixes winstonjs#511
    Alex Bell committed Mar 16, 2015
    Configuration menu
    Copy the full SHA
    1b82fa5 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2015

  1. feat(lib): File based transports should retry stream creation on error

    This commit only deals with streams created by the transport.
    
    Changes:
    - Adds public property `maxRetries` -> defaults 2
    - Adds internal property `failures` -> # of failed stream creation attempts
    - Transport will attempt to re-create the stream on errors
    - Will attempt to re-create while `failures < maxRetries`
    Alex Bell committed Mar 18, 2015
    Configuration menu
    Copy the full SHA
    804d62c View commit details
    Browse the repository at this point in the history
  2. feat(lib): File transports' logging perform NOOP when in a failed state

    This commit adds a conditional check to file / daily-rotate-file tranports
    logging function. We check to make that the transport isn't currently in a
    failed state (i.e failures >= maxRetries) if it is in a failed state then
    we perform a NOOP and return an error to the logging callback.
    Alex Bell committed Mar 18, 2015
    Configuration menu
    Copy the full SHA
    350d7ac View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2015

  1. feat(test): Adds failed file transport unit tests

    changes:
    - 2 tests added under file-test & daily-rotate-file-test
    - 1 helper function added that is named `assertFailedTransport`
    Alex Bell committed Mar 19, 2015
    Configuration menu
    Copy the full SHA
    b710b7e View commit details
    Browse the repository at this point in the history
  2. doc(readme): Updates FileTransport Options

    Alex Bell committed Mar 19, 2015
    Configuration menu
    Copy the full SHA
    7c89e37 View commit details
    Browse the repository at this point in the history