Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Missing defaultMeta in log entry while using Profiler #1935

Closed
wants to merge 1 commit into from
Closed

Fix: Missing defaultMeta in log entry while using Profiler #1935

wants to merge 1 commit into from

Conversation

HonzaMac
Copy link

fixes #1665

@DABH DABH mentioned this pull request Jan 15, 2022
Open
@maverick1872
Copy link
Member

Since the logger instance is the thing actually doing the "write" operation (sorta) I feel it most appropriate to let it also run the "_addDefaultMetadata" logic instead of redefining it on the Profiler class. As such I've implemented this fix with the fixes for the overarching metadata issues in #1989

Ref: #2029

@maverick1872
Copy link
Member

@HonzaMac Are you alright with me closing this and favoring the overarching implementation I've been working through in the above mentioned PR?

@HonzaMac
Copy link
Author

HonzaMac commented Feb 9, 2022

This could be closed in favour od better implemention you work on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ra100 ra100 ra100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Profiler.done doesn't respect defaultMeta.
3 participants
@HonzaMac @maverick1872 @ra100