root & child meta-data

[hraban]

I've added a test for root & child logger which both define metadata. If I understand the docs correctly, this should pass?

[maverick1872]

@hraban @fearphage Sorry I am just now seeing this. Do you mind if I ensure I have this test case covered in the implementation in #1989 and then close this guy?

[hraban]

By all means, this wasn't necessarily a PR so much as a bug report. Thanks for checking in and good luck.

[maverick1872]

@hraban this should be covered by this test case in my PR. As such I'll be closing this.

[zeroxx1986]

As of today, this issue is still present & I don't see the referenced particular test case in the main repo at all.

[hraban]

@zeroxx1986 seems like it was reverted a few days after merging:

• https://github.com/winstonjs/winston/commits/master/test/unit/winston/logger.test.js
• the revert: Revert for 2103 #2104
• the regression which that revert intended to address: [Bug]: TypeError encountered when logging class extending superclass which contains protected property #2103 (still open)

I don't use winston anymore so I'm out of the loop. Good luck!

[wbt]

@zeroxx1986 Is it fixed in 3.7.1? It is correct that the changes were reverted shortly after merge because they broke some things and we don't like breaking changes without a major version bump; the work to fix the breakage and restore the changes hasn't happened yet.