Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Use Buffer.alloc and Buffer.from instead of new Buffer #1281

Merged
merged 1 commit into from
Apr 20, 2018
Merged

[fix] Use Buffer.alloc and Buffer.from instead of new Buffer #1281

merged 1 commit into from
Apr 20, 2018

Conversation

ChrisAlderson
Copy link
Member

Changed two instances of new Buffer to Buffer.alloc/Buffer.from. Fixes #1244.

@indexzero
Copy link
Member

Thanks for fixing these @ChrisAlderson – just in time for node@10 release!

@indexzero indexzero merged commit e84a7b6 into winstonjs:master Apr 20, 2018
indexzero added a commit that referenced this pull request Apr 20, 2018
@ChrisAlderson
Copy link
Member Author

No problem, glad I cloud help.

@ChrisAlderson ChrisAlderson deleted the fix/buffer branch April 25, 2018 06:42
cjbarth pushed a commit to cjbarth/winston that referenced this pull request Aug 22, 2018
* commit 'dc74db60b8d46475fce04bab1e0c31abe5201e09': (34 commits)
  [dist] Maintenance release. 2.4.3
  [Winston 2.x] Decycle circular `Error` instances (winstonjs#1307)
  [dist] Maintenance release. 2.4.2
  [dist] Add .gitattributes file.
  [fix] Backport winstonjs#1281 onto 2.x for maintenance.
  [dist] Add ignores from 3.x for easier maintenance switching.
  fix: clone() cloning prototype's custom methods (winstonjs#1086)
  Don't swallow Error message/stack when using formatter (winstonjs#1188)
  [dist] Add package-lock.json
  Update http.js - Add support for headers
  fix 2.x readme (fixes winstonjs#1179)
  [dist] Maintenance release. 2.4.1
  Always pass a function to fs.close (winstonjs#1227)
  Update documentation for the `stringify` option
  [dist] Version bump. 2.4.0
  [fix] Correct documentation mistake in 2.x
  Add how to colorize output in the custom formatter example (winstonjs#989)
  [fix] Container.add() 'filters' and 'rewriters' option passing to logger (winstonjs#1036)
  Fixed working of "humanReadableUnhandledException" parameter when additional data is added in meta (winstonjs#1066)
  Added filtering by log level (winstonjs#1040)
  ...
Mizumaki pushed a commit to Mizumaki/winston that referenced this pull request Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants